Refactor for compatibility update#26
Open
liuyiqiandrew wants to merge 12 commits into
Open
Conversation
# Conflicts: # bbpower/bandpasses.py # bbpower/compsep.py # bbpower/fg_model.py # bbpower/param_manager.py # bbpower/power_specter.py # examples/generate_SO_maps.py # examples/generate_SO_spectra.py # examples/utils.py # test/run_compsep_test.sh # test/run_polychord_test.sh # test/run_power_specter_test.sh # test/run_sampling_test.sh # test/test_config_predicted_spectra.yml
Collaborator
|
Thanks @liuyiqiandrew . I think the overall direction is the correct one, but I worry that this PR is almost impossible to review. It would need to be broken down into smaller PRs in which it is easy to see for reviewers what has actually changed in the code. I think the aim is to give BBPower a complete overhaul in any case, shedding a lot of the stuff that is not really used or useful. So perhaps we can use this as a place to look for inspiration in that effort, but merging the PR as it is would be really difficult. It took me 30s just to scroll through the changes as fast as my mousepad would let me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility update for python>=3.10 and up-to-date package dependencies.
Better code with: typehinting, docstrings, unit test, black formating, documentation.
@kwolz