Skip to content

Remove UV to UP downgrade check #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
happydude wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove UV to UP downgrade check #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/Controller/AuthProcess.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,19 +163,6 @@ public function main(Request $request): Response
$debugEnabled,
);

/** Custom check: if the token was initially registered with UV, but now
* authenticates only UP, we don't allow this downgrade.
*
* This is not typically allowed by authenticator implementations anyway
* (they typically require a full reset of the key to remove UV
* protections) but to be safe: find out and tell user to re-enroll with
* the lower security level. (level upgrades are of course OK.)
*/
if ($oneToken[5] > $authObject->getPresenceLevel()) {
// phpcs:ignore Generic.Files.LineLength.TooLong
throw new Exception("Token was initially registered with higher identification guarantees than now authenticated with (was: " . $oneToken[5] . " now " . $authObject->getPresenceLevel() . "!");
}

// no matter what: if we are passwordless it MUST be presence-verified
if (
$state['FIDO2PasswordlessAuthMode'] === true &&
Expand Down