Be lenient in what we accept, like dateTime/time with trailing sub-se…#86
Open
Be lenient in what we accept, like dateTime/time with trailing sub-se…#86
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
============================================
- Coverage 91.67% 91.58% -0.09%
- Complexity 945 948 +3
============================================
Files 219 219
Lines 3423 3435 +12
============================================
+ Hits 3138 3146 +8
- Misses 285 289 +4 🚀 New features to boost your workflow:
|
tvdijen
force-pushed
the
feature/strip-trailing-zeros
branch
3 times, most recently
from
be7ebcd to
c66dc1e
Compare
Member
Author
tvdijen
force-pushed
the
feature/strip-trailing-zeros
branch
from
97119cc to
18f44da
Compare
Contributor
Member
Author
|
I think I may have made a booboo here, because I mixed up lexical value with canonical value.. The lexical value does allow trailing zero's for sub-seconds, so any XML containing this is valid. We just shouldn't store them because they are insignificant. |
tvdijen
force-pushed
the
feature/strip-trailing-zeros
branch
from
d32a4e5 to
f215dc0
Compare
tvdijen
force-pushed
the
feature/strip-trailing-zeros
branch
from
f215dc0 to
40bbd21
Compare
tvdijen
force-pushed
the
feature/strip-trailing-zeros
branch
from
40bbd21 to
0c0e4c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cond zeros
Closes #85