fix: emcn component library design engineering polish#3672
fix: emcn component library design engineering polish#3672adithyaakrishna wants to merge 4 commits intosimstudioai:stagingfrom
Conversation
PR SummaryMedium Risk Overview Adds a Tailwind Improves a11y/UX polish: larger hit areas for small controls (e.g., modal close, checkbox/switch/slider thumbs, tag remove), disables animations under Written by Cursor Bugbot for commit 74c6b77. This will update automatically on new commits. Configure here. |
|
@adithyaakrishna is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
| primary: | ||
| 'bg-[#1D1D1D] text-[var(--text-inverse)] hover:text-[var(--text-inverse)] hover:bg-[#2A2A2A] dark:bg-white dark:hover:bg-[#E0E0E0]', | ||
| destructive: 'bg-[var(--text-error)] text-white hover:text-white hover:brightness-106', | ||
| 'bg-[var(--c-1D1D1D)] text-[var(--text-inverse)] hover-hover:text-[var(--text-inverse)] hover-hover:bg-[var(--c-2A2A2A)] dark:bg-white dark:hover-hover:bg-[var(--c-E0E0E0)]', |
There was a problem hiding this comment.
Missing CSS variable --c-1D1D1D causes invisible buttons
High Severity
The primary button variant references var(--c-1D1D1D) for its background and related colors, but --c-1D1D1D is not defined in the extended palette in globals.css. My grep of the entire globals.css confirmed zero matches for 1D1D1D. Other color variables like --c-2A2A2A and --c-E0E0E0 are defined, but --c-1D1D1D is missing from both light and dark theme sections. This means the primary button variant and the active button-group item will have no background color, making them visually broken.
Additional Locations (1)
| 'bg-[var(--brand-tertiary-2)] text-[var(--text-inverse)] hover-hover:text-[var(--text-inverse)] hover-hover:bg-[#2DAC72] dark:bg-[var(--brand-tertiary-2)] dark:hover-hover:bg-[#2DAC72] dark:text-[var(--text-inverse)] dark:hover-hover:text-[var(--text-inverse)]', | ||
| ghost: 'text-[var(--text-secondary)] hover-hover:text-[var(--text-primary)]', | ||
| subtle: | ||
| 'text-[var(--text-body)] hover-hover:text-[var(--text-body)] hover-hover:bg-[var(--surface-4)]', |
There was a problem hiding this comment.
Ghost-secondary button lost hover text color change
Medium Severity
The ghost-secondary variant only defines text-[var(--text-muted)] with no hover state. Previously, the base button class included hover:text-[var(--text-primary)] which applied to all variants. Now that the base class no longer sets text color or hover text color, each variant is responsible for its own. The ghost-secondary variant lost its hover feedback, unlike ghost and other variants which explicitly define hover-hover:text-[var(--text-primary)].
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| <DismissableLayerBranch | ||
| className={cn( | ||
| 'fixed z-[10000201] min-w-[120px]', | ||
| 'fixed z-[calc(var(--z-popover)+1)] min-w-[120px]', |
There was a problem hiding this comment.
Submenu z-index far below parent popover z-index
High Severity
The hover submenu portal z-index changed from z-[10000201] to z-[calc(var(--z-popover)+1)] which resolves to 201, but the parent PopoverContent at line 583 still uses z-[10000200]. The submenu now renders far below its parent popover in the stacking order, making nested submenus invisible (hidden behind the parent).


Summary
Comprehensive polish of the emcn compos library along with addressing a11y issues and design token consistency
Type of Change
Testing
Checklist