Skip to content

fix(icons): restore the Crunchbase mark's counter and framing - #6887

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/crunchbase-icon
Aug 20, 2026
Merged

fix(icons): restore the Crunchbase mark's counter and framing#6887
waleedlatif1 merged 1 commit into
stagingfrom
fix/crunchbase-icon

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The cb mark is one path whose b counter was previously carved out by the plate path's winding. With the plate removed the counter filled in under nonzero, so the b rendered as a solid blob — evenodd restores the hole.
  • Reverts the viewBox to the mark's authentic 0 0 32 32 framing. The retargeted 2.19 0.66 27.5 27.5 box blew the glyph up to ~75% of the tile and pushed it off-center; at 0 0 32 32 it sits at Crunchbase's own 64% and is centered.
  • Block bgColor (#0287D1) is unchanged — the glyph still draws on currentColor so the tile supplies the blue.
  • Same fix applied to the docs copy of the icon.

Type of Change

  • Bug fix

Testing

Rendered the mark on the block tile before and after; bun run lint, bun run check:audits (32/32), and bun run generate-docs (no drift) all pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 20, 2026 6:37am

Request Review

@cursor

cursor Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Cosmetic SVG-only changes to a shared icon with no logic, auth, or data impact.

Overview
Fixes Crunchbase block/docs tile rendering for CrunchbaseIcon in apps/sim/components/icons.tsx and apps/docs/components/icons.tsx.

The mark path lost its “b” counter when winding no longer carved the hole under default nonzero fill; fillRule / clipRule evenodd restores the interior hole so the glyph is not a solid blob.

viewBox is adjusted from the tight 2.19 0.66 27.5 27.5 crop to 2 2 28 28, so the logo is centered and sized like Crunchbase’s own framing instead of oversized and off-center on the tile. currentColor and block bgColor are unchanged.

Reviewed by Cursor Bugbot for commit 9139053. Configure here.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Bumped the mark's viewBox to 2 2 28 28 — a uniform scale of the same authentic artwork, so the cb reads at the tile's optical weight instead of sitting small inside it.

@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates both Crunchbase icon copies to restore the glyph counter and adjust its framing.

  • Adds even-odd fill and clipping rules to the Crunchbase path.
  • Keeps the Sim and documentation icon implementations synchronized.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/docs/components/icons.tsx Updates the documentation copy of CrunchbaseIcon with even-odd path handling and revised SVG framing.
apps/sim/components/icons.tsx Updates the application CrunchbaseIcon with matching counter and framing changes.

Reviews (2): Last reviewed commit: "fix(icons): restore the Crunchbase mark'..." | Re-trigger Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@waleedlatif1
waleedlatif1 merged commit f5728fa into staging Aug 20, 2026
23 of 24 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/crunchbase-icon branch August 20, 2026 06:34

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9139053. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant