fix(icons): restore the Crunchbase mark's counter and framing - #6887
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The mark path lost its “b” counter when winding no longer carved the hole under default
Reviewed by Cursor Bugbot for commit 9139053. Configure here. |
56a0475 to
9139053
Compare
|
Bumped the mark's viewBox to |
Greptile SummaryThe PR updates both Crunchbase icon copies to restore the glyph counter and adjust its framing.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/docs/components/icons.tsx | Updates the documentation copy of CrunchbaseIcon with even-odd path handling and revised SVG framing. |
| apps/sim/components/icons.tsx | Updates the application CrunchbaseIcon with matching counter and framing changes. |
Reviews (2): Last reviewed commit: "fix(icons): restore the Crunchbase mark'..." | Re-trigger Greptile
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9139053. Configure here.
Summary
cbmark is one path whosebcounter was previously carved out by the plate path's winding. With the plate removed the counter filled in undernonzero, so thebrendered as a solid blob —evenoddrestores the hole.0 0 32 32framing. The retargeted2.19 0.66 27.5 27.5box blew the glyph up to ~75% of the tile and pushed it off-center; at0 0 32 32it sits at Crunchbase's own 64% and is centered.bgColor(#0287D1) is unchanged — the glyph still draws oncurrentColorso the tile supplies the blue.Type of Change
Testing
Rendered the mark on the block tile before and after;
bun run lint,bun run check:audits(32/32), andbun run generate-docs(no drift) all pass.Checklist