improvement(tables): disable the default view's delete action with a tooltip - #6897
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Uses Reviewed by Cursor Bugbot for commit 130db81. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR keeps the default view’s Delete action visible but inert, with dimmed styling and an explanatory tooltip.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking defects identified. The disabled action remains focusable and hoverable for its tooltip, while its click path prevents default behavior, stops propagation, and returns before deletion.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.tsx | Adds a tooltip-wrapped, aria-disabled Delete action for default views while preserving event suppression and hidden-row action behavior. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.test.tsx | Updates the ViewsMenu test to assert that both Delete actions render and that activating the default view’s action does not call the deletion callback. |
Reviews (1): Last reviewed commit: "improvement(tables): disable the default..." | Re-trigger Greptile
Summary
Type of Change
Testing
Views-menu unit tests updated and passing; lint and the full audit suite pass
Checklist