Skip to content

[monk] Fix SCK channel cancelling, expire Zenith Stomp when Zenith fades #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renanthera merged 2 commits into from
Jul 31, 2026
+3 −1
Merged

[monk] Fix SCK channel cancelling, expire Zenith Stomp when Zenith fades #11649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c995e2e
[monk] Zenith fades Zenith Stomp buffs on expiry.
renanthera Jul 31, 2026
1122f57
[monk] Set Spinning Crane Kick channel to execute on player. SCK need…
renanthera Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion engine/class_modules/monk/sc_monk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1688,6 +1688,7 @@ struct spinning_crane_kick_t : public monk_melee_attack_t

void execute() override
{
set_target( player );
auto *tick = spinning_crane_kick_tick;
if ( !tick->execute_state )
tick->execute_state = tick->get_state();
Expand Down Expand Up @@ -6476,7 +6477,8 @@ void monk_t::create_buffs()
buff.whirling_dragon_punch = make_buff_fallback<buffs::whirling_dragon_punch_buff_t>(
talent.windwalker.whirling_dragon_punch->ok(), this, "whirling_dragon_punch" );

buff.zenith = make_buff_fallback<buffs::zenith_t>( talent.windwalker.zenith->ok(), this, "zenith" );
buff.zenith = make_buff_fallback<buffs::zenith_t>( talent.windwalker.zenith->ok(), this, "zenith" )
->set_expire_callback( [ & ]( buff_t *, int, timespan_t ) { buff.zenith_stomp->expire(); } );

buff.zenith_stomp = make_buff_fallback( talent.windwalker.tigereye_brew_3->ok(), this, "zenith_stomp",
talent.monk.zenith_stomp_buff );
Expand Down
Loading