Skip to content

[Warlock] Apply Gloomhound and Isolated Implosion hotfixes #11654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyterage merged 1 commit into from
Aug 1, 2026
+19 −8
Merged

[Warlock] Apply Gloomhound and Isolated Implosion hotfixes #11654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions engine/class_modules/warlock/sc_warlock_actions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3288,8 +3288,7 @@ using namespace helpers;
spell_power_mod.direct = p->talents.implosion_aoe->effectN( 1 ).sp_coeff();
aoe = -1;
target_filter_callback = secondary_targets_only();
// NOTE: 2026-07-06: The spell description lists 125% effectiveness, but in-game damage behaves as +125% increased effectiveness (bug?)
base_dd_multiplier *= ( p->bugs ? 1.0 : 0.0 ) + p->tier.wl_demonology_12_1_class_set_4pc->effectN( 2 ).percent();
base_dd_multiplier *= p->tier.wl_demonology_12_1_class_set_4pc->effectN( 2 ).percent();
}
};

Expand All @@ -3303,8 +3302,7 @@ using namespace helpers;
spell_power_mod.direct = p->talents.implosion_aoe->effectN( 1 ).sp_coeff();
aoe = 0;
radius = 0;
// NOTE: 2026-07-06: The spell description lists 150% effectiveness, but in-game damage behaves as +150% increased effectiveness (bug?)
base_dd_multiplier *= ( p->bugs ? 1.0 : 0.0 ) + p->tier.wl_demonology_12_1_class_set_4pc->effectN( 1 ).percent();
base_dd_multiplier *= p->tier.wl_demonology_12_1_class_set_4pc->effectN( 1 ).percent();

impact_action = new isolated_implosion_aoe_secondary_t( p );
impact_action->stats = stats;
Expand Down
21 changes: 17 additions & 4 deletions engine/class_modules/warlock/sc_warlock_pets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,17 +1316,34 @@ vilefiend_t::vilefiend_t( warlock_t* owner )
{
npc_id = owner->talents.gloomhound->effectN( 1 ).misc_value1();
npc_suffix = "vilefiend";
// 2026-08-01: Validated coefficients
if ( sim->dbc->wowv() >= wowv_t( 12, 1, 0 ) )
{
owner_coeff.ap_from_sp = 0.6075;
owner_coeff.sp_from_sp = 2.6325;
}
else
{
owner_coeff.ap_from_sp = 0.45;
owner_coeff.sp_from_sp = 1.95;
}
}
else if ( owner->talents.mark_of_fharg.ok() )
{
npc_id = owner->talents.charhound->effectN( 1 ).misc_value1();
npc_suffix = "vilefiend";
// 2026-08-01: Validated coefficients
owner_coeff.ap_from_sp = 0.45;
owner_coeff.sp_from_sp = 1.95;
}
else
{
npc_id = owner->talents.vilefiend->effectN( 1 ).misc_value1();
// NOTE: 2026-07-11 Regular Vilefiend do not trigger Hellbent Commander on heartbeat (bug?)
triggers.hellbent_commander_heartbeat &= !bugs;
// 2026-08-01: Validated coefficients
owner_coeff.ap_from_sp = 0.45;
owner_coeff.sp_from_sp = 1.95;
}

// NOTE: 2026-07-11 Vilefiend do not trigger Hellbent Commander on demise (must wait to player heartbeat) (bug?)
Expand All @@ -1340,10 +1357,6 @@ vilefiend_t::vilefiend_t( warlock_t* owner )
if ( sim->dbc->wowv() < wowv_t( 12, 1, 0 ) )
affected_by.demonic_brutality = false;

// 2026-02-17: Validated coefficients
owner_coeff.ap_from_sp = 0.45;
owner_coeff.sp_from_sp = 1.95;

owner_coeff.health = 0.75;

bile_spit_executes = 1; // Only one Bile Spit per summon
Expand Down
Loading