Add Webhooks#3960
Conversation
|
unicorn |
|
unicorn |
|
I reviewed this PR. A few things I noticed:
Overall the list is well-established and covers the topic thoroughly. |
Review of awesome-webhooksI took a close look at the awesome-webhooks list. Here are my findings: What's done well
Issues that should be addressed1. Defunct/deprecated services in the Outgoing section Several entries link to services that no longer exist or have been substantially rebranded. A curated list should not include dead links. Examples:
These should be removed or updated to their current names/URLs. 2. Promotional language in the README intro The intro contains "contact me on Twitter @_adeel" and a "Share this list on Twitter" link. Per awesome list guidelines, the README should focus on the curated content. Self-promotion and social sharing CTAs should be removed or moved to contributing.md. 3. Questionable entry in Development Tools "Vedika API" is described as a "Vedic astrology API with webhook support." This is not a webhook development tool — it's a domain-specific API that happens to support webhooks. By that logic, thousands of APIs could be listed. This entry does not fit the section and dilutes the list's curation quality. 4. Formatting inconsistency between sections The Outgoing section uses the format 5. Missing notable modern webhook providers The Outgoing list is heavily weighted toward 2015-2017 era services and is missing many major modern webhook providers. Some notable omissions:
Adding these would significantly improve the list's current relevance. 6. Many documentation links are likely broken Given that many entries are 8-10 years old, a significant number of the 7. Alphabetical ordering not consistent in Development Tools Entries in the Development Tools section are not strictly alphabetically ordered (e.g., "Webhook Debugger" entries appear after "webhook.site", "WebReducer" comes after "Webhook Wizard"). This should be cleaned up. SummaryThe list covers a real, well-defined topic and has a genuine 10-year history, which is commendable. However, the curation quality needs improvement before it meets the standard expected of an awesome list. The main concerns are: (1) multiple defunct services that should be pruned, (2) promotional text in the intro, (3) at least one off-topic entry, and (4) missing major modern providers that would make the list more useful today. I'd recommend asking the maintainer to address items 1-4 before merging. |
wolffcatskyy
left a comment
There was a problem hiding this comment.
Several issues with this PR:
-
Checklist format: The PR uses a simplified checklist that does not match the required
pull_request_template.md. Many required checkboxes from the template are missing entirely (e.g., logo requirement, hard-wrapping, CI badge check, etc.). -
PR reviews missing: The updated template requires reviewing at least 4 other open PRs with detailed feedback. The PR body does not mention any reviews. This is a required step per the guidelines.
-
unicornconfirmation: The template requires posting the wordunicornas a comment to confirm all guidelines were read. This is not present in the body. -
Description ends without period: The entry description in the PR body ends with "...and educational content." — that's fine. But the actual diff should be checked to confirm the added line in
readme.mdalso ends with a period. -
URL missing
#readme: The submitted URLhttps://github.com/realadeel/awesome-webhooksis missing the required#readmesuffix. The entry inreadme.mdshould link tohttps://github.com/realadeel/awesome-webhooks#readme. -
Logo: The list doesn't appear to have a logo/illustration at the top of the readme, which is a requirement ("whenever possible").
🤖 This review was generated by Claude AI assisting a maintainer.
|
[Nitpick}: The PR coment only lists 2 reviewed PRs while the requirement is at least 4. |
|
Useful topic! The list needs some updates to meet current guidelines:
|
|
Closing for lack of response. |
https://github.com/realadeel/awesome-webhooks
Webhooks are the backbone of real-time integrations across the modern web. This list curates resources for webhook providers, consumers, and developers — covering outgoing webhook APIs (Stripe, GitHub, Slack, etc.), incoming webhook endpoints, development/debugging tools, community resources, and educational content.
The list has been actively maintained for 10 years, has 227+ stars, 26 forks, and 16 contributors.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Add Name of List.#readme.main.awesome-listandawesomeas GitHub topics.Contents.contributing.md).