Skip to content

CI: Build docker on PR and push when tags are created#2056

Closed
orgads wants to merge 1 commit intosipwise:masterfrom
audiocodes:ci-docker
Closed

CI: Build docker on PR and push when tags are created#2056
orgads wants to merge 1 commit intosipwise:masterfrom
audiocodes:ci-docker

Conversation

@orgads
Copy link
Copy Markdown
Contributor

@orgads orgads commented Jan 23, 2026

No description provided.

@orgads
Copy link
Copy Markdown
Contributor Author

orgads commented Jan 23, 2026

You need to configure DOCKERHUB_USERNAME in vars and DOCKERHUB_TOKEN in secrets for push to work. The token should be generated for sipwise user (assuming you own it...).

@mika
Copy link
Copy Markdown
Member

mika commented Jan 29, 2026

Thanks, basically LGTM, just wondering whether we should use the github docker registry instead? 🤔

(We - as in Sipwise - abandoned docker usage back in 2023-03 due to Docker's sunsetting of Free Team organizations, not claiming that this is a hard NO for us right now, but we're discussing/checking our options and what would serve useful)

@mika
Copy link
Copy Markdown
Member

mika commented Feb 6, 2026

@orgads maybe you want to take a look at #2063 and see whether that would be useful for you?

@mika
Copy link
Copy Markdown
Member

mika commented Apr 10, 2026

@orgads see e.g. https://github.com/sipwise/rtpengine/releases/tag/mr13.5.1.9 - is that useful for you or is there still any need for docker builds?

@orgads
Copy link
Copy Markdown
Contributor Author

orgads commented Apr 10, 2026

@mika Thank you! This is very close to what I need. If I install libavcodec-extra, will the extra codecs like AMR be supported, or does it need to be available on build time?

And can you also publish for arm64?

@orgads
Copy link
Copy Markdown
Contributor Author

orgads commented Apr 10, 2026

Ok, I found the answer for AMR - it works (if I install libavcodec-extra). So only arm64 is an open issue.

                 AMR: fully supported
              AMR-WB: fully supported

Thanks again!

@orgads
Copy link
Copy Markdown
Contributor Author

orgads commented Apr 10, 2026

Pushed a PR for arm64:

@rfuchs
Copy link
Copy Markdown
Member

rfuchs commented Apr 10, 2026

Ok, closing this then

@rfuchs rfuchs closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants