Give the Context script API meaningful types#2478
Merged
Merged
Conversation
The two arguments script authors always touch — context.options and context.result — were typed as bare Object, so "context.options." returned no completions in any editor. Re-type them (and the taskData scratch space) as Record<string, any>, which keeps the runtime behavior unchanged but lets IntelliSense show what's there. Move "target" inside compilerOptions where it actually takes effect, and drop a couple of @typedef blocks that had been parked inside a constructor body. Co-authored-by: Claude noreply@anthropic.com Change-Id: I079355e096d366c6cc328ee2c2cb23491f4250a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two arguments script authors always touch — context.options and
context.result — were typed as bare Object, so "context.options."
returned no completions in any editor. Re-type them (and the taskData
scratch space) as Record<string, any>, which keeps the runtime behavior
unchanged but lets IntelliSense show what's there. Move "target" inside
compilerOptions where it actually takes effect, and drop a couple of
@typedef blocks that had been parked inside a constructor body.
Co-authored-by: Claude noreply@anthropic.com
Change-Id: I079355e096d366c6cc328ee2c2cb23491f4250a6