Tighten types on the mouse and measure surfaces#2479
Merged
Conversation
commands.mouse was an anonymous object literal, so every parameter showed up as any in IntelliSense and hover. Replace the inline @type {Object} placeholder with a real shape so selector is typed as string and singleClick's options surface their waitForNavigation flag instead of any. measure.stop, clickAndMeasure, and stopAsError were documented with bare @returns {Promise}, which TypeScript emits as Promise<any> — that silently masks any downstream assumption about what comes back. Mark stopAsError as Promise<void> (it returns nothing) and the two others as Promise<unknown> so callers have to acknowledge the result shape rather than inheriting any. Co-authored-by: Claude noreply@anthropic.com Change-Id: I176fd306ee24324f3792663341845b281d9087e0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commands.mouse was an anonymous object literal, so every parameter
showed up as any in IntelliSense and hover. Replace the inline
@type {Object} placeholder with a real shape so selector is typed
as string and singleClick's options surface their waitForNavigation
flag instead of any.
measure.stop, clickAndMeasure, and stopAsError were documented
with bare @returns {Promise}, which TypeScript emits as Promise
— that silently masks any downstream assumption about what comes back.
Mark stopAsError as Promise (it returns nothing) and the two
others as Promise so callers have to acknowledge the result
shape rather than inheriting any.
Co-authored-by: Claude noreply@anthropic.com
Change-Id: I176fd306ee24324f3792663341845b281d9087e0