Skip to content

ci: drop stale 'stable' branch from workflow triggers#317

Open
level09 wants to merge 1 commit into
mainfrom
cleanup-stable-branch-references
Open

ci: drop stale 'stable' branch from workflow triggers#317
level09 wants to merge 1 commit into
mainfrom
cleanup-stable-branch-references

Conversation

@level09
Copy link
Copy Markdown
Collaborator

@level09 level09 commented Apr 15, 2026

Summary

The stable branch was a Git Flow holdover pinned to commit 0b6f5f9 (the original notification system PR #50, hundreds of commits behind main). It carried no unique commits, no unique tags, and no documentation referenced it. Keeping it around was actively misleading — anyone browsing the branch list and assuming stable was the production branch would have been wrong by years of work.

It has been deleted from origin. Releases are now tagged directly from main following modern trunk-based practice (which is what we just did with v4.0.0).

This PR removes the four workflow files that listed stable as a push trigger so they no longer reference a non-existent branch.

Changes

  • .github/workflows/checks.yml (Tests: pytest) — removed - stable
  • .github/workflows/pip-audit.yml (Security: Python) — removed - stable
  • .github/workflows/fe-js-audit.yml (Security: JavaScript) — removed - stable
  • .github/workflows/semgrep.yml (Security: SAST) — removed - stable

All four workflows still trigger on pull_request, workflow_dispatch, push to main, and (where applicable) their existing schedule: cron entries. Functionality is unchanged.

Verification before deletion

Verified stable was safe to delete before pulling the trigger:

  • git merge-base --is-ancestor origin/stable main → YES (every commit on stable was already on main)
  • git log origin/stable ^main → empty (zero unique commits)
  • git tag --merged origin/stable vs git tag --merged main → no tags uniquely reachable from stable
  • No documentation, install guide, deploy script, or CODEOWNERS referenced stable

Test plan

  • CI runs on this PR (pull_request trigger still works)
  • After merge, push to main still triggers all four workflows

The 'stable' branch was a Git Flow holdover pinned to an ancient commit
(notification system PR #50) and has been deleted from origin. Releases
are now tagged directly from main following modern trunk-based practice.
This removes the four workflow files that listed 'stable' as a push
trigger so they no longer reference a non-existent branch.
@level09 level09 self-assigned this Apr 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d92445e2-ca33-4cab-bd0f-f85329da8c71

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup-stable-branch-references

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant