ci: drop stale 'stable' branch from workflow triggers#317
Open
level09 wants to merge 1 commit into
Open
Conversation
The 'stable' branch was a Git Flow holdover pinned to an ancient commit (notification system PR #50) and has been deleted from origin. Releases are now tagged directly from main following modern trunk-based practice. This removes the four workflow files that listed 'stable' as a push trigger so they no longer reference a non-existent branch.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
stablebranch was a Git Flow holdover pinned to commit0b6f5f9(the original notification system PR #50, hundreds of commits behindmain). It carried no unique commits, no unique tags, and no documentation referenced it. Keeping it around was actively misleading — anyone browsing the branch list and assumingstablewas the production branch would have been wrong by years of work.It has been deleted from origin. Releases are now tagged directly from
mainfollowing modern trunk-based practice (which is what we just did withv4.0.0).This PR removes the four workflow files that listed
stableas a push trigger so they no longer reference a non-existent branch.Changes
.github/workflows/checks.yml(Tests: pytest) — removed- stable.github/workflows/pip-audit.yml(Security: Python) — removed- stable.github/workflows/fe-js-audit.yml(Security: JavaScript) — removed- stable.github/workflows/semgrep.yml(Security: SAST) — removed- stableAll four workflows still trigger on
pull_request,workflow_dispatch,pushtomain, and (where applicable) their existingschedule:cron entries. Functionality is unchanged.Verification before deletion
Verified
stablewas safe to delete before pulling the trigger:git merge-base --is-ancestor origin/stable main→ YES (every commit on stable was already on main)git log origin/stable ^main→ empty (zero unique commits)git tag --merged origin/stablevsgit tag --merged main→ no tags uniquely reachable from stablestableTest plan