Skip to content

feat: add enable_helm input for helmCharts overlays#7

Open
hisco wants to merge 1 commit into
mainfrom
enable-helm-kustomize-deploy
Open

feat: add enable_helm input for helmCharts overlays#7
hisco wants to merge 1 commit into
mainfrom
enable-helm-kustomize-deploy

Conversation

@hisco
Copy link
Copy Markdown
Contributor

@hisco hisco commented May 2, 2026

Summary

  • Adds enable_helm input (default true) that passes --enable-helm to all kustomize build invocations in this action.
  • Threads the input through to the kustomize-inspect and kustomize-apply steps so helm-based overlays succeed end-to-end.
  • Fails fast in Validate inputs if enable_helm: true but the helm binary is not on the runner.

Notes

Test plan

  • Deploy an overlay using helmCharts: with helm installed - detect, inspect, plan summary, and apply all succeed.
  • Deploy with enable_helm: false on a non-helm overlay - behaves as before.
  • Deploy with enable_helm: true on runner without helm - fails fast in Validate inputs.

Note

Medium Risk
Changes the default kustomize build behavior to pass --enable-helm (and now requires helm on runners unless disabled), which can break existing pipelines that don't have helm installed. It also threads this flag into downstream inspect/apply steps, affecting end-to-end deployment execution.

Overview
Adds a new enable_helm input (default true) to support overlays using helmCharts: by passing --enable-helm to this action’s internal kustomize build calls (mode detection and plan summary).

When enable_helm is on, the action now fails fast during input validation if the helm binary is missing, and it forwards enable_helm to skyhook-io/kustomize-inspect@v1 and skyhook-io/kustomize-apply@v1. Documentation is updated to describe the new input and its requirements.

Reviewed by Cursor Bugbot for commit 2a2f6a9. Bugbot is set up for automated code reviews on this repo. Configure here.

Defaults to true so overlays using helmCharts: work out of the box.
When true, fails fast if the helm binary is not on the runner.

Threaded through to kustomize-inspect and kustomize-apply steps so
helm-based overlays succeed end-to-end.
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2a2f6a9. Configure here.

Comment thread action.yml
enable_helm:
description: 'Pass --enable-helm to kustomize build (requires helm binary on runner). When true, fails fast if helm is not installed.'
required: false
default: 'true'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking default: enable_helm requires helm on all runners

High Severity

The new enable_helm input defaults to 'true', which is a backward-incompatible change. Previously no --enable-helm flag was passed and no helm binary was required. Now every existing user of this action will have the validation check at line 108 enforce that helm is on PATH, and --enable-helm will be appended to all kustomize build calls. Any runner (especially self-hosted) without helm installed will fail immediately, even for overlays that don't use helmCharts. The safe default is 'false' so existing workflows are unaffected and users opt in explicitly.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2a2f6a9. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant