-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add opt-in dry_run input to skip commit/apply #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dry-run step writes to stdout, not step summary
Medium Severity
The PR description and test plan explicitly state that the dry-run step writes to
$GITHUB_STEP_SUMMARYfor review in the run UI, and includes the fullkustomize buildoutput. However, the implementation only usesechoto stdout —GITHUB_STEP_SUMMARYappears nowhere in the file. The dry-run output will be buried in action logs instead of being surfaced in the GitHub step summary panel, which defeats the stated purpose of the feature. Thekustomize buildoutput mentioned in the description is also absent.Reviewed by Cursor Bugbot for commit 9c96e14. Configure here.