feat(bench): add --out summary CSV flag + verify v0.5.35 CLI hot-path baseline#247
Merged
Merged
Conversation
… baseline Two related additions for v0.6.0 release readiness, both surfaced during the 2026-05-15 baseline-bench pass on the Windows 7-drive reference box. ## scripts/windows/cross-tool-benchmark.rs Add a `--out <path>` flag that writes the post-run summary as a plain-CSV alongside the existing stdout tables. Twelve-column schema (`tool,phase,sink,drive,pattern,p50_ms,p95_ms,rows,bad, verdict,rounds_ok,rounds_total`), integer milliseconds + integer row counts, intermediate directories created on demand, exits 2 on write failure. Distinct from the existing `<cwd>/uffs_bench_out.csv` daemon-side file (raw per-query rows, overwritten every round); the banner block prints both paths up front so operators see where each artefact lands. Unknown CLI flags now warn on stderr (`warning: unknown flag "--foo" ignored`) instead of silently swallowing — caught during the same 2026-05-15 bench where a typo-`--out` in pre-flag-support runs left the operator hunting a non-existent CSV file. ## CHANGELOG.md - New `Verified — v0.5.35 baseline CLI hot-path bench` subsection records plan §1 goal-4 PASSED: current v0.5.96 is universally faster than v0.5.35 across all 5 patterns (drive D, 7.07 M records, 30 rounds, HOT phase), with `ext_dll` (44 529 rows) showing a 2.7× speedup (94→35 ms p50). Row-count parity preserved exactly across both versions on every pattern. Capture: `LOG/memory output` (manual paste). - New `Added — cross-tool benchmark script: --out summary CSV` subsection documents the new flag, CSV column schema, and the unknown-flag-warns improvement. ## Verification - `just lint-pre-push` — 23/23 gates green (54s). - Bench script compiles cleanly via standalone `rustc --edition 2021 --emit=metadata` on Mac (frontmatter intact, no warnings).
5c50e10 to
8c6bd59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone v0.6.0 release-readiness work, surfaced during the 2026-05-15 baseline-bench pass on the Windows 7-drive reference box.
Plan §1 goal-4 (no CLI hot-path regression) — VERIFIED
Captured 2026-05-15 on the 7-drive reference box (drive D,
7.07 M records, 30 rounds, HOT phase, p50/p95 wall_ms):
exactprefixext_rareext_dllsubstringCurrent v0.5.96 is universally faster than v0.5.35 on every
pattern. Row-count parity preserved exactly across both versions
(no result-set drift). Capture:
LOG/memory output(manualstdout paste — the bench script's
--outflag was not yetavailable for this run).
New bench-script feature:
--out <path>scripts/windows/cross-tool-benchmark.rslearned a--out <path>flag that writes the post-run summary as plain CSV (12 columns:
tool,phase,sink,drive,pattern,p50_ms,p95_ms,rows,bad,verdict, rounds_ok,rounds_total). Intermediate directories are createdon demand; the writer exits 2 on failure. Distinct from the
existing
<cwd>/uffs_bench_out.csvdaemon-side file (rawper-query row dumps). Banner block now prints both paths up
front so operators see exactly where each artefact lands.
Unknown CLI flags now warn on stderr (
warning: unknown flag "--foo" ignored) instead of silently swallowing — caught duringthe 2026-05-15 baseline bench where a typo-
--outinpre-flag-support runs left the operator hunting a non-existent
CSV file.
v0.6.0 bake gate status (with this PR)
All v0.6.0 readiness gates green. Only the one-week
mainbakeremains per
memory-tiering-bake-criteria.md.
Verification
just lint-pre-push— 23/23 gates green (54s pre-commit; 50spre-push initial; 3s pre-push post-rebase — bucket 2 skipped
since no rust/dep/infra files changed).
rustc --edition 2021 --emit=metadataon Mac (frontmatter intact, no warnings).plus a Windows-only rust-script.
Files touched
CHANGELOG.md— two new subsections under v0.6.0 staging:### Verified — v0.5.35 baseline CLI hot-path bench (2026-05-15)and
### Added — cross-tool benchmark script: --out summary CSV flag.scripts/windows/cross-tool-benchmark.rs—--outflagplumbing +
write_summary_csvimpl (~80 LOC of new code) +unknown-flag warning + banner-block restructuring.