-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add optional filepath argument to run command #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: zimeg-fix-env-quote
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,7 +216,7 @@ The application's app-level token and bot access token will be provided as envir | |
|
|
||
| All Bolt SDKs leverage this `start` hook operating mode. | ||
|
|
||
| A custom start path can be set with the `SLACK_CLI_CUSTOM_FILE_PATH` variable. | ||
| A custom start path can be provided as a positional argument to the `run` command (e.g., `slack run ./src/app.py`), which sets both the `SLACK_APP_PATH` and `SLACK_CLI_CUSTOM_FILE_PATH` environment variables for the hook process. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: Thank you for updating this and choosing to support both at first. #backwards-compatible
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mwbrooks If it helps upgrades go smooth I think it's meaningful - I appreciate your help in thinking through this 🧠 💡 ✨ |
||
|
|
||
| ##### Output | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣️ note: IIRC this activity level flag isn't used often so we might encourage examples that outline another common use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👾 ramble: I'm now curious if this flag updates a
LOG_LEVELenvironment variable forruncommand?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we can probably remove it as an example since it's Deno/ROSI specific as well.
thought: In the future, we will probably introduce a
--log-levelflag that the CLI will use and pass into Bolt Frameworks. The same log level should be passed into the Deno SDK and could be inherited by--activity-levelfor Deno apps.The end result would be a universal log-level flag that works for all frameworks and ROSI.