refactor: remove legacy CLIVersion field and SetVersion option

[mwbrooks]

Changelog

• N/A

Summary

This pull request removes the legacy CLIVersion field and SetVersion() function from ClientFactory.

• Removes the CLIVersion field and SetVersion() functional option from ClientFactory.
• Removes stale TODO comment referencing a circular dependency that no longer exists. This was solved by slackcontext.Version(ctx).
• Replaces indirect version access (clients.CLIVersion) with direct version.Raw() calls. The clients.CLIVersion was previously set to the raw version value.

Context:

ClientFactory.CLIVersion and shared.SetVersion() were a workaround for a circular dependency between internal/api/client.go and package version. That dependency no longer exists - internal/api/client.go does not import the version package and the API client now reads the CLI version from context with slackcontext.Version(ctx).

Test Steps

1. Test Version:

$ lack version
# → Expect: "Using slack v3.15.0-26-ga164d25"

$ lack --version
# → Expect: "Using slack v3.15.0-26-ga164d25"

2. Test Version Override with Environment Variable:

$ SLACK_TEST_VERSION=v0.0.1 lack version
# → Expect: "Using slack v0.0.1"

3. Test Doctor Command (confirms Config.Version is set):

$ lack doctor
# → Expect:
#     ✔ CLI (this tool for building Slack apps)
#      Version: v3.15.0-26-ga164d25

4. Test Debug Output (confirms version reaches context)

$ lack auth list --verbose --skip-update 2>&1 | grep -i "version"
# → Expect: "cli_version":"3.15.0-26-ga164d25"

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.22%. Comparing base (ad9ddd9) to head (24e129b).

Files with missing lines	Patch %	Lines
main.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   70.23%   70.22%   -0.02%     
==========================================
  Files         220      220              
  Lines       18446    18444       -2     
==========================================
- Hits        12956    12952       -4     
- Misses       4316     4318       +2     
  Partials     1174     1174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.