Skip to content

style: use command section headers in create command output #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 5 commits into from
May 13, 2026
+13 −13
Merged

style: use command section headers in create command output #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1550d72
style: use command section headers in create output
zimeg May 13, 2026
b98a4af
test: before push
zimeg May 13, 2026
f993a19
Merge branch 'main' into zimeg-style-create-headers
mwbrooks May 13, 2026
f28d0b3
Merge branch 'main' into zimeg-style-create-headers
mwbrooks May 13, 2026
bd36090
style: suggest next steps with similar wording
zimeg May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/project/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ func printCreateSuccess(ctx context.Context, clients *shared.ClientFactory, appP

clients.IO.PrintInfo(ctx, false, "%s", style.Sectionf(style.TextSection{
Emoji: "clipboard",
Text: "Next steps to begin development",
Text: "Next Steps",
Secondary: secondaryOutput,
}))
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/project/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func printNextStepSection(ctx context.Context, clients *shared.ClientFactory, pr

clients.IO.PrintInfo(ctx, false, "%s", style.Sectionf(style.TextSection{
Emoji: "clipboard",
Text: "Next steps to begin development",
Text: "Next Steps",
Secondary: secondaryOutput,
}))
}
14 changes: 7 additions & 7 deletions cmd/project/init_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ func Test_Project_InitCommand(t *testing.T) {
cm.IO.On("ConfirmPrompt", mock.Anything, app.LinkAppConfirmPromptText, mock.Anything).Return(false, nil)
},
ExpectedStdoutOutputs: []string{
"Project Initialization", // Assert section header
"App Link", // Assert section header
"Next steps to begin development", // Assert section header
"Project Initialization", // Assert section header
"App Link", // Assert section header
"Next Steps", // Assert section header
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
// Assert installing project dependencies
output := cm.GetCombinedOutput()
require.Contains(t, output, "Installed project dependencies")
require.Contains(t, output, "Project Dependencies")
require.Contains(t, output, "Added "+filepath.Join("project-name", ".slack"))
require.Contains(t, output, "Added "+filepath.Join("project-name", ".slack", ".gitignore"))
require.Contains(t, output, "Added "+filepath.Join("project-name", ".slack", "hooks.json"))
Expand Down Expand Up @@ -148,9 +148,9 @@ func Test_Project_InitCommand(t *testing.T) {
).Return(api.GetAppStatusResult{}, nil)
},
ExpectedStdoutOutputs: []string{
"Project Initialization", // Assert section header
"App Link", // Assert section header
"Next steps to begin development", // Assert section header
"Project Initialization", // Assert section header
"App Link", // Assert section header
"Next Steps", // Assert section header
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
// Assert prompt to add existing apps was called
Expand Down
8 changes: 4 additions & 4 deletions internal/pkg/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func Create(ctx context.Context, clients *shared.ClientFactory, createArgs Creat
)
clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{
Emoji: "open_file_folder",
Text: "Created a new Slack project",
Text: "Project Create",
Secondary: projectDetails,
}))

Expand Down Expand Up @@ -447,16 +447,16 @@ func InstallProjectDependencies(

// Start the spinner
spinnerText := fmt.Sprintf(
"Installing project dependencies %s",
style.Secondary("(this may take a few seconds)"),
"Project Dependencies %s",
style.Secondary("(installing... this may take a second)"),
)
spinner := style.NewSpinner(clients.IO.WriteErr())
spinner.Update(spinnerText, "").Start()

// Stop the spinner when the function returns
defer func() {
spinnerText = style.Sectionf(style.TextSection{
Text: "Installed project dependencies",
Text: "Project Dependencies",
Secondary: outputs,
})
spinner.Update(spinnerText, "package").Stop()
Expand Down
Loading