Skip to content

Canton: FQ ref#2075

Open
stackman27 wants to merge 2 commits into
mainfrom
sish/addfqref
Open

Canton: FQ ref#2075
stackman27 wants to merge 2 commits into
mainfrom
sish/addfqref

Conversation

@stackman27
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings May 19, 2026 03:26
@stackman27 stackman27 requested review from a team as code owners May 19, 2026 03:26
@github-actions
Copy link
Copy Markdown

👋 stackman27, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Canton-specific FeeQuoter address reference to lane configuration so downstream lane setup can carry the raw FeeQuoter instance reference needed for MCMS-related operations.

Changes:

  • Adds FeeQuoterRef datastore.AddressRef to CantonLaneConfig.
  • Documents that the reference includes the raw instance address for MCMS operations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stackman27 stackman27 changed the title FQ ref Canton: FQ ref May 19, 2026
@stackman27 stackman27 closed this May 19, 2026
@stackman27 stackman27 reopened this May 21, 2026
@github-actions
Copy link
Copy Markdown

Metric sish/addfqref main
Coverage 70.0% 69.7%

@stackman27 stackman27 added this pull request to the merge queue May 21, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 21, 2026
GlobalConfig datastore.AddressRef
// FeeQuoterRef is the Canton FeeQuoter contract address reference.
// This includes the raw instance address needed for MCMS operations.
FeeQuoterRef datastore.AddressRef
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployment/lanes shouldn't be used for 2.0. Everything should be in chainlink-ccip/deployment/v2_0_0/changesets/configure_chains_for_lanes_from_topology.go

Also, can't Canton just fetch the address ref the same way as the other chains?

GetFQAddress(ds datastore.DataStore, chainSelector uint64) ([]byte, error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants