update invariants to improve wording#2088
Open
RensR wants to merge 1 commit into
Open
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the invariants documentation around pool finality handling to more precisely describe that the default TokenPool implementation does not re-validate requested finality on the destination chain (inbound releaseOrMint), while still requiring the interface to carry enough information for alternative pool implementations to enforce destination-side policy if desired.
Changes:
- Expands
INV-POOL-8to clarify where allowed-finality is enforced and how inbound finality is used by the default pool. - Renames and rewrites the pool-finality enforcement section in
FINALITY_INVARIANTS.mdto describe optional inbound enforcement by pool implementations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| chains/evm/contracts/invariants/TOKEN_POOL_INVARIANTS.md | Clarifies V2 pool interface behavior and default inbound finality handling. |
| chains/evm/contracts/invariants/FINALITY_INVARIANTS.md | Refactors the “pool enforcement” invariant wording to reflect default vs optional inbound enforcement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matYang
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the wording to properly convey that the default pool does not validate finality config on dest, but pools must get enough params to do this validation if they wanted to.