[Solana] Add RMN Curser role, independent from RMN owner#2092
Closed
toblich wants to merge 12 commits into
Closed
Conversation
|
* feat: token ref resolver * fix: CI gomod issue * fix: move test * docs: re-word artifical address ref label comment * test: update configure_tokens_for_transfers_test * fix: gomod CI * fix: typo in comment * fix: add nil check for token pool version * fix: no panic in decodeArtificialPoolAddressRef * fix: add zero address check for pool PDA * chore: copilot feedback * fix: update environment datastore in each loop iteration for manual reg. * chore: address copilot feedback * fix: use fully resolved ref in TPRL * chore: use underscore for unused datastore parameter * fix: only normalize if there is indeed something to normalize * chore: update comment in test * fix: block empty address refs after normalize * fix: copilot feedback * fix: add extra nil safety check * chore: clean up * fix: grammar in comment * fix: ensure env datastore is updated on each loop iteration * refactor: reuse helper function in findRef * fix: show derive error * chore: add clarifying note * chore: fix comment * fix: make log more informative * refactor: clean up code * fix: pass bundle * chore: fix gomod for CI * chore: revert noisy datastore formatting * feat: skip datastore if address is already present in the ref * fix: best-effort tidy token roles * test: enable address ref resolvers in v2 tokens_test * test: fix unpopulated token ref edge case * fix: token ref should not be overwritten * fix: bump go mod for CI * fix: update error message * fix: GetCurrentInboundRateLimit should fail if fast finality is true for pre-V2 adapters * fix: error format string * chore: prefer chain.Selector over input.Selector * docs: update stale comment * refactor: standardize DeployTokenPool * chore: bump gomod for ci * chore: rename ParseAllowList * fix: inverted condition * test: fixes * fix: ToNonZeroEVMAddress * refactor: rename TokenInfo to ERC20Decimals * fix: edge case zero address handling * fix: typo in comment Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: remove duplicate import * fix: use nonzero address for fetchTokenGovernor * fix: ResolveRouterAddress preserve behavior in comment * docs: update v2 token pool adapter comment * fix: add better error message for fetchTokenGovernor * fix: SetRateLimitAdmin now returns a slice of writes * fix: allow rate limit admin to be set to zero address (i.e. reset) --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* feat: allow token expansion to configure token transfer fees * fix: token transfer fee resolution * fix: remove duplicate import * fix: remove duplicate import * fix: remove duplicate import * fix: compare selectors * fix: copilot feedback for optional yaml unmarshaling * fix: revert unnecessary edge case handling * test: improve testing coverage for optional with config struct
* initial impl of the changeset * reduce PR verbosity * further simplifications * add 2 hasAdminRole token types * add unit test * refactor: tests and changeset * docs: update comment * feat: add fallback account support * fix: resolve typo in comment * fix: use nBytes in helper and fix grammer in comment * chore: address copilot feedback * fix: error message * test: add coverage for mixed timelock and deployer key admin role * fix: bump gomod so that CI passes * chore: make warn logs more explicit --------- Co-authored-by: chris-de-leon-cll <147140544+chris-de-leon-cll@users.noreply.github.com>
| pub default_code_version: CodeVersion, | ||
|
|
||
| // --- v3 fields below --- | ||
| pub curser: Pubkey, // the only account authorized to curse subjects. |
Contributor
There was a problem hiding this comment.
Isn't the owner also allowed to curse?
toblich
force-pushed
the
solana/rmn-curser
branch
from
c0504a6 to
a332a53
Compare
|
|
|
|
Contributor
Author
|
Closing just because GitHub UI is showing the wrong list of commits compared to the base branch - will open a new PR that hopefully shows the right diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.