Add curse validation to applyCurse and applyUncurse#2098
Merged
Conversation
crispymangoes
requested review from
AmrMohamedRezk,
KodeyThomas,
agusaldasoro,
asoliman92,
carte7000,
matYang and
winder
|
👋 crispymangoes, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
KodeyThomas
previously approved these changes
May 28, 2026
RensR
reviewed
May 28, 2026
| action.SubjectChainSelector, | ||
| ) | ||
| } | ||
| if action.ChainSelector == action.SubjectChainSelector { |
Collaborator
There was a problem hiding this comment.
nit: can move this check up to avoid duping it on line 32. Maybe even just combine with the check on 28
if action.IsGlobalCurse || action.ChainSelector == action.SubjectChainSelector {
Collaborator
There was a problem hiding this comment.
Do we even need to make this exception? It wouldn't do anything if we removed this check right?
RensR
reviewed
May 28, 2026
| } | ||
|
|
||
| key := laneKey{source: action.ChainSelector, target: action.SubjectChainSelector} | ||
| actionInfo := curseActionInfo{ |
Collaborator
There was a problem hiding this comment.
super nitty nit: i'd just inline this
RensR
previously approved these changes
May 28, 2026
|
RensR
approved these changes
May 28, 2026
KodeyThomas
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.