feat: allow finality config to be set via DeployTokenPoolInput#2100
Merged
chris-de-leon-cll merged 3 commits intoMay 28, 2026
Merged
Conversation
chris-de-leon-cll
requested review from
AmrMohamedRezk,
KodeyThomas,
agusaldasoro,
asoliman92,
carte7000,
Copilot,
matYang and
winder
|
sowgandhi11
approved these changes
May 28, 2026
matYang
approved these changes
May 28, 2026
chris-de-leon-cll
deleted the
feat/set-finality-config-using-deploy-pool-input
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment the token pool finality config can only be set via
TokenExpansionusingConfigureTokensForTransfersInput.AllowedFinalityConfigThis is a bit awkward to use because if there are multiple connections being made to the same pool, then you can technically specify different finality configs for the same pool in the YAML, which can lead to confusion about what will actually make it on-chain
Instead, this PR makes
AllowedFinalityConfiga property ofDeployTokenPoolInputso that there is less ambiguity about what the finality config will be in these situations