poc: std HeadTracker and RMNCurseReader conformance#1051
Draft
makramkd wants to merge 1 commit into
Draft
Conversation
|
Code coverage report:
Files added (in
|
makramkd
commented
Apr 27, 2026
Comment on lines
+17
to
+30
| type RMNCurseHarness interface { | ||
| // DeployRMN deploys or ensures an RMN Remote–equivalent and returns the | ||
| // address the [chainaccess.RMNCurseReader] under test must use. Second | ||
| // and later calls may return the same address if idempotent, or an error | ||
| // if a second deploy is not supported. | ||
| DeployRMN(ctx context.Context) (rmnAddress protocol.UnknownAddress, err error) | ||
| // CurseRMN curses the given subjects (e.g. chain selectors or global | ||
| // curse as [protocol.Bytes16]). | ||
| CurseRMN(ctx context.Context, subjects []protocol.Bytes16) error | ||
| // ClearRMNCurses removes all curses so a subsequent | ||
| // [chainaccess.RMNCurseReader.GetRMNCursedSubjects] returns the empty | ||
| // slice (or the chain’s pre-curse baseline). Safe to call when already clear. | ||
| ClearRMNCurses(ctx context.Context) error | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Can probably be replaced by CurseAdapter but this is just a PoC - real implementation would use CurseAdapter to reduce duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a PoC of a suite of conformance tests for some accessor interfaces (currently just RMNCurseReader and HeadTracker).
This was me guiding the AI through a lot of it, but I think there can be improvements, mainly around e.g. the RMNCurseReader, since we might be able to use the standard
CurseAdapterfrom the deployment API instead of the custom harness for this suite, but that would look a bit complex for the PoC.I provided samples of how the conformance suites would be run for the existing EVM source reader.