Conversation
karen-stepanyan
had a problem deploying
to
integration
GitHub Actions
Failure
karen-stepanyan
temporarily deployed
to
integration
GitHub Actions
Inactive
karen-stepanyan
temporarily deployed
to
integration
GitHub Actions
Inactive
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WASM host’s “user metrics enabled” gating from a static bool to a context-aware limits.GateLimiter, aligning the host-side emitMetric check with the existing limits/settings infrastructure and allowing runtime overrides via CRE settings.
Changes:
- Replace
ModuleConfig.EnableUserMetrics boolwithModuleConfig.EnableUserMetricsLimiter limits.GateLimiter. - Default
EnableUserMetricsLimiterto a closed gate when unset to avoid nil usage. - Update
emitMetricto callEnableUserMetricsLimiter.AllowErr(ctx)instead of checking a boolean; adjust tests accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/workflows/wasm/host/module.go | Replaces config flag with a GateLimiter and initializes a default limiter when nil. |
| pkg/workflows/wasm/host/execution.go | Switches metric emission gating to AllowErr(ctx) on the configured gate limiter. |
| pkg/workflows/wasm/host/wasm_nodag_test.go | Updates tests to use the new limiter-based config and relies on default-closed behavior when unset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jmank88
approved these changes
Apr 7, 2026
pavel-raykov
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous EnableUserMetrics bool field was never set by any caller (always defaulted to false), making user metrics permanently disabled with no way to enable them. The UserMetricEnabled setting in cresettings/defaults.toml and the GateLimiter in EngineLimiters existed but were disconnected from the actual WASM host gate check.
Core PR - smartcontractkit/chainlink#21868