Bound capability call's max concurrency#2074
Merged
Merged
Conversation
|
👋 justinkaseman, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a per-execution concurrency bound for asynchronous host calls (capability calls and secrets retrieval) made from WASM workflows, to avoid unbounded goroutine growth and backpressure these operations when the limit is reached.
Changes:
- Add
ModuleConfig.MaxPendingCallswith a default value and wire it into module creation/execution. - Introduce a per-execution semaphore and use it to bound concurrency in
callCapAsyncandgetSecretsAsync. - Update tests that directly construct
executionto initialize the new semaphore field.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
pkg/workflows/wasm/host/module.go |
Adds MaxPendingCalls config/defaulting and initializes the per-execution semaphore. |
pkg/workflows/wasm/host/execution.go |
Uses the semaphore to cap concurrent goroutines for capability/secrets async calls. |
pkg/workflows/wasm/host/module_test.go |
Initializes pendingCallsSem in a concurrency-related test execution instance. |
pkg/workflows/wasm/host/execution_await_order_test.go |
Initializes pendingCallsSem in await-ordering test execution instance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| if modCfg.MaxPendingCalls == 0 { | ||
| modCfg.MaxPendingCalls = defaultMaxPendingCalls |
Contributor
There was a problem hiding this comment.
Worth being a uint maybe?
Contributor
Author
There was a problem hiding this comment.
This doesn't add cleanly with the ResourcePoolLimiter. We would have to cast it everywhere.
I'll just add the guard.
justinkaseman
force-pushed
the
fix/bound-callcap-goroutines
branch
from
6cead5b to
b932fc6
Compare
cedric-cordenier
previously approved these changes
May 20, 2026
cedric-cordenier
previously approved these changes
May 20, 2026
jmank88
reviewed
May 22, 2026
jmank88
previously approved these changes
May 22, 2026
jmank88
previously approved these changes
May 22, 2026
bolekk
previously approved these changes
May 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
bolekk
previously approved these changes
May 22, 2026
jmank88
reviewed
May 22, 2026
jmank88
previously approved these changes
May 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
bolekk
approved these changes
May 22, 2026
jmank88
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.