Add data feeds cache and proxy bindings - #162
Open
Fletch153 wants to merge 6 commits into
Open
Conversation
Soroban Contract Test Coverage92.64% line coverage — 18001 / 19431 lines hit
Per-Contract Breakdown
Full file-level coverage report |
Collaborator
Author
|
The five failing Go CI checks (E2E, Go Unit Tests, Integration ×2, Coverage) are pre-existing on main with byte-identical failure signatures — not introduced here: deployment/adapters references CommitteeVerifierClient.GetAllSignatureConfigs, which is absent from the bindings at current main, so every Go job fails at build. All contract-side checks (test-contracts, formatting, generated code) pass. |
Fletch153
force-pushed
the
feature/DF-25434/data-feeds-deployment
branch
from
July 22, 2026 19:26
aeaff42 to
3410c65
Compare
Fletch153
changed the title
This was referenced Jul 22, 2026
Fletch153
force-pushed
the
feature/DF-25434/data-feeds-deployment
branch
from
July 23, 2026 13:21
c393651 to
9b5104c
Compare
Fletch153
changed the title
Fletch153
force-pushed
the
feature/DF-25434/data-feeds-deployment
branch
7 times, most recently
from
July 23, 2026 15:20
f7386a7 to
d6b704d
Compare
Fletch153
force-pushed
the
feature/DF-25434/data-feeds-deployment
branch
from
July 23, 2026 16:00
d6b704d to
fda599a
Compare
Fletch153
force-pushed
the
feature/DF-25429/data-feeds-contracts
branch
from
July 23, 2026 18:16
019b250 to
14b9721
Compare
Fletch153
force-pushed
the
feature/DF-25434/data-feeds-deployment
branch
5 times, most recently
from
July 23, 2026 19:35
24dc50e to
62fb6b4
Compare
Three additive capabilities the data feeds contracts need; output for all existing contracts is unchanged (verified byte-identical): - soroban_sdk::I256 maps to *big.Int via new scval.I256ToScVal / I256FromScVal (4x64-bit two's-complement limb packing, range-checked) - -readonly takes an explicit, typo-guarded list of read-only functions per contract, replacing the get_*/is_* name heuristic when present - the parser now parses void functions (no return clause) instead of silently dropping them; -include-void names, per contract, the void functions that get generated methods All per-function policy (void inclusion, read-only classification) is resolved in main before generation: the function list is filtered and each function stamped ReadOnly, so codegen renders the model with no policy awareness. Also adds the missing soroban_sdk::String event-field decode case and gofmt-canonical output.
Generated from the contracts/data-feeds nested workspace via the existing pipeline: gen_interfaces builds the nested workspace into the shared target dir (CARGO_TARGET_DIR), so its wasm artifacts are picked up like every other contract's; gen_bindings gains the readonly_fns and include_void_fns columns, set only on the data feeds rows. Reads (latest_round, find_round, ...) generate as free simulations per the explicit list; the ownership/upgrade void functions are opted in by name; generated files are marked linguist-generated for review.
The data feeds changesets (chainlink deployment/data-feeds/changeset/ stellar) deploy the cache with a CreateContractV2 constructor argument and upload replacement wasm for upgrades: - DeployContractWithArgs / DeployContractBytesWithArgs build the create-contract host function with optional constructor args - UploadContractWASM returns the wasm hash for upgrade flows Concrete Deployer methods only; the stellardeps.SorobanContractDeployer interface is unchanged — consumers needing the new methods define their own interface over the concrete type.
Fletch153
force-pushed
the
feature/DF-25434/data-feeds-deployment
branch
from
July 23, 2026 19:43
62fb6b4 to
667504a
Compare
- Handle I256 params, returns, tuple elements, and Vec<I256> in client codegen; import math/big only when a signature needs it - Add scval.I256SliceToScVal and extend the round-trip test - Decode #[topic] event fields from the event topic list; the value-map switch left them silently zero (DataId, DonId, ConfigVersion) — regenerates cre and data_feeds_cache clients - Fold generated-file formatting and writing into writeGoFile
The fee bump was applied only to BaseFee, but rent and event fees are paid from the resource fee declared in the soroban transaction data, which was copied verbatim from simulation. When ledger state drifted between simulate and submit, transactions failed with an insufficient-refundable-fee error that no BaseFee bump could fix. Apply the same cushion to the declared resource fee; the unused refundable portion is refunded after execution.
Both scripts skipped missing inputs with a log line and exited 0, so a renamed wasm or omitted build left stale committed output that the check-generated diff gate could not see.
Fletch153
marked this pull request as ready for review
July 27, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*big.Int, an explicit-readonlyfunction list, and-include-void.DeployContract{,Bytes}WithArgs(constructor args) andUploadContractWASMfor the CLD changesets.Context
Stacked on #161 (whose tip adds explicit discriminants to
Bound, making the generator's U32 unit-enum encoding correct forfind_roundwith no generator changes). Soroban's contract spec carries no view marker, so reads that don't match the generator'sget_*/is_*heuristic —latest_round,find_round,round_range,decimals,description— are declared per contract ingen_bindings.sh's newreadonly_fnscolumn; listed functions generate as free simulations, and a listed name that doesn't exist in the contract fails generation (typo/rename guard). CCIP rows don't use the new columns and keep today's behavior exactly.Changes
soroban_sdk::I256→*big.Intvia newscval.I256ToScVal/I256FromScVal;-readonlyexplicit list (authoritative when present, heuristic otherwise);-include-voidtakes a per-contract list naming the void functions to generate (transfer_ownership,upgrade, … — previously dropped silently); unlisted void functions stay omitted, so CCIP can opt individual functions in later without new machinery; missingsoroban_sdk::Stringevent-field decode case added.gen_interfaces.sh: data-feeds rows with awasm_dircolumn (nested cargo workspace) and the nested build. No alias handling needed: Add data feeds cache, proxy, and common contracts #161 now writesBytesN<N>literally, so the wasm spec is self-contained.gen_bindings.sh:readonly_fns+include_voidcolumns, set only on data-feeds rows.bindings/contracts/data_feeds_{cache,proxy}/(marked linguist-generated, collapsed in review); the generated surface is enforced by check-generated CI and verified by the implementor.stellardeps.SorobanContractDeployerwidened (consumed by chainlink #23213); test fakes embed the interface.Testing
bindings:go test ./...— generator and scval (i256 round-trips) — all pass.deployment:go test ./operations/... ./sequences/... ./cre/... .— all pass (pre-existingdeployment/adaptersbreak, issue CI red on main: adapters call CommitteeVerifierClient.GetAllSignatureConfigs, missing from bindings #163, unchanged from main).gen_bindings.sh --no-interfaces+ gofmt → clean tree); interface regeneration with CI's exact stellar-cli version (25.1.0) +cargo fmtreproduces every committed CCIP.rsbyte-for-byte.Notes
76ac73e) for theBounddiscriminants.Call[T]client and v0/v1 generator-split explorations are parked onspike/DF-25434/two-step-clientfor future reference.🤖 Generated with Claude Code