-
Notifications
You must be signed in to change notification settings - Fork 6
[NONEVM-5091] Migrate contracts to 1.4 #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patricios-space
wants to merge
20
commits into
main
Choose a base branch
from
chore/contracts/upgrade-tolk-1.3.0-1.4.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
94ac0ab
chore: bump tolk to 1.3.0
patricios-space cbcbf15
feat: bump tolk version to 1.3.0
patricios-space 3f28813
fix: replace tupples with arrays or lisp_lists
patricios-space d8b1905
todo: RemainingBitsOrRef custom encode/decode
patricios-space 0c0d475
fix: typeAndVersion return literalSlice(), not string
patricios-space 698ec7c
fix: int? casting
patricios-space 86a62a8
fix: broken imports
patricios-space 6b6e29b
ref: cleanup
patricios-space 24a3866
ref: replace string functions with compile-time methods
patricios-space 8f3ba30
fix: inline facilityId
patricios-space 999b2e1
fix: createEmptyMap() deprecated
patricios-space 62b1454
feat: bump contract versions
patricios-space 94d5e84
feat: bump compiler to tolk 1.4.1
patricios-space 0b22ac6
fix: bump contract versions to tolk 1.4.1
patricios-space 165f01a
fix: /// doc comments only supported in top level
patricios-space cab9b7b
feat: update contract metadata
patricios-space 208b4d4
fix: override vulnerable axios version
patricios-space e55a53b
fmt: missing line and TS file
patricios-space 60cdb09
feat: specify version by qualifier
patricios-space d2f94e6
fix: old axios version vulnerability
patricios-space File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| const MerkleRoot_FACILITY_NAME = "link.chain.ton.ccip.MerkleRoot"; | ||
| const MerkleRoot_FACILITY_ID = 186; // (crc32(<facility>) % 640) + 10 | ||
| const MerkleRoot_FACILITY_ID = MerkleRoot_FACILITY_NAME.crc32() % 640 + 10; // 186 | ||
| // NOTE: inlined getFacilityId because compiler doesn't allow custom compile time functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these constants
x__FACILITY_NAMEandCONTRACT_VERSION- is there a specific reason we additionally need those everywhere vs. just defining the type and version once in thetypeAndVersion()func?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite typeAndVersion being a pure and constant function that could be computed at compile time, comp-time methods like crc32 only work with constant strings.