[DO NOT MERGE] canary: force DON2DON non-determinism to validate mixed-env - #23291
Draft
prashantkumar1982 wants to merge 2 commits into
Draft
[DO NOT MERGE] canary: force DON2DON non-determinism to validate mixed-env#23291prashantkumar1982 wants to merge 2 commits into
prashantkumar1982 wants to merge 2 commits into
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
|
|
prashantkumar1982
force-pushed
the
cre/mixed-env-canary-test
branch
from
July 31, 2026 18:51
93c8bb0 to
828f32a
Compare
prashantkumar1982
force-pushed
the
cre/mixed-env-non-determinism
branch
from
July 31, 2026 19:08
41c2e2f to
b4be2da
Compare
prashantkumar1982
force-pushed
the
cre/mixed-env-canary-test
branch
from
July 31, 2026 19:12
828f32a to
e8e7507
Compare
prashantkumar1982
force-pushed
the
cre/mixed-env-non-determinism
branch
from
July 31, 2026 20:11
b4be2da to
8b25b56
Compare
prashantkumar1982
force-pushed
the
cre/mixed-env-canary-test
branch
3 times, most recently
from
August 3, 2026 16:19
9ba41a3 to
604f6de
Compare
prashantkumar1982
force-pushed
the
cre/mixed-env-non-determinism
branch
from
August 3, 2026 18:20
8b25b56 to
63aada7
Compare
prashantkumar1982
force-pushed
the
cre/mixed-env-canary-test
branch
from
August 3, 2026 18:29
604f6de to
ca6403c
Compare
…d-env Temporary canary to verify the mixed-env non-determinism check catches a real divergence in CI, without breaking unit tests. - capability_executor.go: when CRE_CANARY_NONDETERMINISM is set, unconditionally stamps Metadata.OrgID on executable-capability requests (ignoring PropagateOrgIDInRequestMetadata). PR-built nodes then emit a different request payload than develop-built nodes; the capability DON logs "received messages with the same id and different payloads", which the mixed-env TestMain scan turns into "Non-Determinism introduced". - mixed-env-don.toml.tmpl: set CRE_CANARY_NONDETERMINISM on the workflow DON so the canary activates only in the mixed-env e2e run (unit tests unaffected). Revert this commit once CI has demonstrated the catch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ed-env Second canary, at the OCR3 report-attestation layer. In vault/plugin.go wrapReportWithKeyBundleInfo, when CRE_CANARY_NONDETERMINISM is set, perturb the SIGNED report bytes on PR-built nodes so vault OCR3 nodes disagree during report attestation (the state/outcome is already committed by then, so this is a clean report-phase divergence). libocr logs "This is commonly caused by non-determinism in the ReportingPlugin", which the mixed-env gate catches (Bucket_B). Also sets CRE_CANARY_NONDETERMINISM on the capabilities DON. An earlier version omitted ReportInfo.Id, but that lives in the unsigned .Info and only broke report routing (a functional test failure), not attestation. Revert with the rest of the canary once CI has demonstrated the catch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
prashantkumar1982
force-pushed
the
cre/mixed-env-canary-test
branch
from
August 3, 2026 19:30
ca6403c to
4a18325
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary canary stacked on top of #23290 (mixed-env topology) to prove the mixed-env non-determinism check actually fires in CI.
What it does:
capability_executor.gounconditionally stampsMetadata.OrgID = "canary-nondeterminism"on executable-capability requests (ignoringPropagateOrgIDInRequestMetadata). PR-built nodes then emit a different request payload than develop-built nodes.Expected result:
received messages with the same id and different payloads.TestMainscan fails themixed-envmatrix entries (Test_CRE_V2_Suite_Bucket_A/_B) withNon-Determinism introduced.Base is the feature branch, so the diff is just the 6-line canary. Close and delete this branch once CI has demonstrated the catch.