[CRE-4955] Use WorkflowTag instead of Tag consistently

[pavel-raykov]

Currently WorkflowActivatedEvent would not carry WorkflowTag but Tag. Note that the latter is never read and hence is not useful. After this PR we start populating WorkflowTag consistently and remove Tag.

Ideally, the WorkflowTag should also be propagated in all the tests using CompileAndDeployWorkflow. However, instead of passing it everywhere, we hardcoded DefaultWorkflowTag for now (if it is needed one can always update CompileAndDeployWorkflow)

[github-actions]

✅ No conflicts with other open PRs targeting develop

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[trunk-io]

   

Failed Test	Failure Summary	Logs
TestDonTimeProvider_GetDONTime_requestTimeout	The test failed because the expected timeout was not reached; instead, fallback to local node time occurred, causing non-deterministic behavior.	Logs ↗︎
Test_CCIP_Messaging_Sui2EVM_Success/Message_to_EVM	The test failed because no commit report events were found on the blockchain within the expected timeout period.	Logs ↗︎
Test_CCIP_Messaging_Sui2EVM_Success	The test failed due to an unspecified error during execution, with no clear indication of the specific cause.	Logs ↗︎

View Full Report ↗︎ ⋅ Docs

[Copilot]

Pull request overview

Risk Rating: MEDIUM

This PR standardizes workflow tag propagation by using WorkflowTag consistently across workflow reconciliation events, syncer handling, and CRE system test registration paths, removing the unused Tag field from v2 syncer event payloads.

Changes:

• Populate WorkflowTag in v2 workflow reconciliation events and update handler logging/labels to reference WorkflowTag (removing Tag from event types).
• Export and reuse DefaultWorkflowTag for workflow registration and HTTP trigger requests in system tests/scripts.
• Extend system-test workflow registration config to carry a workflow tag through to contract registration.

Areas requiring scrupulous human review:

• core/services/workflows/syncer/v2/*: ensure no downstream consumers (metrics, platform events, DB/spec reconciliation, serialization) still rely on the removed Tag field and that WorkflowTag is threaded everywhere required.
• system-tests/lib/cre/workflow/workflow.go:RegisterWithContract: confirm the new tag argument ordering matches all call sites and the underlying contract wrapper expectations.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
system-tests/tests/test-helpers/t_helpers.go	Adds WorkflowTag to registration config and passes it into workflow contract registration; defaults tag in CompileAndDeployWorkflow.
system-tests/tests/regression/cre/http_trigger_regression_test.go	Uses DefaultWorkflowTag for HTTP trigger workflow selection.
system-tests/lib/cre/workflow/workflow.go	Exports DefaultWorkflowTag and threads workflow tag into UpsertWorkflow registration call.
core/services/workflows/syncer/v2/workflow_registry.go	Sets WorkflowTag on generated reconciliation events (and removes the old Tag assignment).
core/services/workflows/syncer/v2/workflow_registry_test.go	Updates expected event payloads to assert on WorkflowTag instead of Tag.
core/services/workflows/syncer/v2/types.go	Removes Tag field from v2 workflow event payload structs, leaving WorkflowTag as the canonical field.
core/services/workflows/syncer/v2/handler.go	Updates event handling/logging/labels to use payload.WorkflowTag.
core/scripts/cre/environment/environment/workflow.go	Passes DefaultWorkflowTag when registering workflows via the script.

Suppressed comments (1)

system-tests/tests/test-helpers/t_helpers.go:819

• workflow.DefaultWorkflowTag is referenced here, but this file already uses the creworkflow import alias for the same package. Referencing the existing alias avoids needing an additional import and prevents the duplicate-import compile error.

		WorkflowName:            workflowName,
		WorkflowLocation:        workflowFileLocation,
		WorkflowTag:             workflow.DefaultWorkflowTag,
		ConfigFilePath:          workflowConfigPath,

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube