Protect template extraction from tar bombs and path traversal - #565
Merged
Conversation
product-security-plaid-production
Bot
requested review from
anirudhwarrier,
ibrajer,
j-nowak,
leeyikjiun and
timothyF95
August 3, 2026 17:25
|
👋 tarcisiozf, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
tarcisiozf
enabled auto-merge
August 3, 2026 19:57
timothyF95
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request strengthens the security and robustness of tarball extraction in the template repository client. It introduces strict limits on tarball download size, extracted file size, total extracted size, and file count to protect against resource exhaustion and malicious archives. The extraction logic is also hardened against path traversal attacks. Comprehensive tests are added to verify these protections.
Security and Resource Limiting Improvements:
client.go).DownloadTarball).extractTarball).extractTarball).