Skip to content

NO-SNOW: Refactor _detect_libc to use platform.libc_ver#2780

Merged
sfc-gh-turbaszek merged 2 commits intomainfrom
turbaszek-glibc
Mar 19, 2026
Merged

NO-SNOW: Refactor _detect_libc to use platform.libc_ver#2780
sfc-gh-turbaszek merged 2 commits intomainfrom
turbaszek-glibc

Conversation

@sfc-gh-turbaszek
Copy link
Copy Markdown
Contributor

Replace file existence checks and subprocess calls with platform.libc_ver() for simpler and more reliable libc detection.

Made-with: Cursor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-turbaszek sfc-gh-turbaszek requested a review from a team as a code owner March 5, 2026 08:12
@sfc-gh-turbaszek sfc-gh-turbaszek added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO_ASYNC_CHANGES labels Mar 16, 2026
Replace file existence checks and subprocess calls with
platform.libc_ver() for simpler and more reliable libc detection.

Made-with: Cursor
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) March 19, 2026 11:12
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 469f300 into main Mar 19, 2026
47 of 49 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the turbaszek-glibc branch March 19, 2026 11:15
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO_ASYNC_CHANGES NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants