Skip to content

Avoid matching platform-specific stream errors - #33

Merged
ioquatix merged 1 commit into
mainfrom
tolerate-closed-stream-message
Aug 19, 2026
Merged

Avoid matching platform-specific stream errors#33
ioquatix merged 1 commit into
mainfrom
tolerate-closed-stream-message

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Closing a socket from another thread raises IOError, but MRI uses different messages across platforms: macOS can report closed stream while other runners report stream closed in another thread.

Assert the stable exception class instead of MRI implementation-specific wording.

Verification:

  • 100 consecutive focused runs with Ruby 4.0
  • Full test suite with Ruby 3.4 and Ruby 4.0
  • RuboCop on the changed test file

Assisted-By: devx/3ed43c18-3c9a-4ad9-a6f5-6668caa29658
@ioquatix
ioquatix force-pushed the tolerate-closed-stream-message branch from 407966a to 8fc6782 Compare August 19, 2026 03:19
@ioquatix
ioquatix merged commit 72b6301 into main Aug 19, 2026
34 of 40 checks passed
@ioquatix
ioquatix deleted the tolerate-closed-stream-message branch August 19, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants