Parse cookie header pairs. - #119
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Parses each semicolon-separated request cookie independently while preserving Set-Cookie attribute semantics.
Changes:
- Split
Cookiefields into individual cookie pairs. - Add coverage for whitespace, duplicates, empty values, and multiple fields.
- Verify
Set-Cookieattributes remain intact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/protocol/http/header/cookie.rb |
Parses each cookie pair independently. |
test/protocol/http/header/cookie.rb |
Tests request cookie parsing behavior. |
test/protocol/http/header/set_cookie.rb |
Tests separate response-cookie semantics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse each semicolon-separated pair in
Cookieheader fields as an independent cookie. This keeps requestCookiesemantics distinct fromSet-Cookieattributes.Tests
bundle exec bake testbundle exec rubocop lib/protocol/http/header/cookie.rb test/protocol/http/header/cookie.rb