build(rewrite): decouple native lib artifacts from core versioning - #1336
Open
msluszniak wants to merge 1 commit into
Open
build(rewrite): decouple native lib artifacts from core versioning#1336msluszniak wants to merge 1 commit into
msluszniak wants to merge 1 commit into
Conversation
…1291) Version the prebuilt native artifacts independently of the npm package. They live on their own GitHub Release tagged v${nativeLibsVersion}-libs, pinned via a new `nativeLibsVersion` field in package.json. The two version lines coincide on a minor cut (core v0.10.0 <-> libs v0.10.0-libs) but drift on patches: a core-only fix keeps the pin (no asset re-upload), an assets-only fix bumps the pin in a core release. The -libs suffix keeps the tags distinct when the numbers match. - download-libs.js: resolve v${nativeLibsVersion}-libs; key the cache on it; fail loudly if the pin is missing. - package-release-artifacts.sh: package/publish against the v*-libs tag with a prerelease-now -> promote-later recipe. - clang-tidy.yml: drop the RNET_BASE_URL test-release override + TODO — the decoupled pin (0.10.0) resolves v0.10.0-libs directly, closing #1291.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Version the prebuilt native artifacts independently of the npm package. They now live on their own GitHub Release tagged
v${nativeLibsVersion}-libs, pinned via a newnativeLibsVersionfield inpackage.json. The two version lines coincide on a minor cut (corev0.10.0↔ libsv0.10.0-libs) but drift on patches: a core-only fix keeps the pin (no asset re-upload), an assets-only fix bumps the pin in a core release. The-libssuffix keeps the tags distinct when the numbers match, and keeps the assets release separate from the core package release.download-libs.js: resolvev${nativeLibsVersion}-libs, key the cache on it, fail loudly if the pin is missing.package-release-artifacts.sh: package/publish against thev*-libstag with a prerelease-now → promote-later recipe.clang-tidy.yml: drop theRNET_BASE_URLtest-release override + TODO — the decoupled pin (0.10.0) resolvesv0.10.0-libsdirectly.The
v0.10.0-libspre-release carrying the artifacts is published, so the resolution works with no override.Introduces a breaking change?
Type of change
Tested on
Testing instructions
From
packages/react-native-executorch, with noRNET_BASE_URLoverride:Resolves
.../releases/download/v0.10.0-libs/headers.tar.gz, downloads, checksum-verifies, and extracts — the exact flow the clang-tidy job runs.Screenshots
Related issues
Closes #1291
Checklist
Additional notes
The
v0.10.0-libsrelease is a pre-release while the native surface for 0.10.0 settles; promote it withgh release edit v0.10.0-libs --prerelease=falseonce final. clang-tidy CI stays gated behindvars.ENABLE_CLANG_TIDY == 'true'.