docs: replace zod examples with valibot - #1634
Merged
Merged
Conversation
Convert the validation examples in server functions, sessions and auth, environment, and the SolidStart migration guide from zod to valibot, matching the fullstack template's switch to valibot. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Restore the zod versions of every validation example and pair them with the valibot versions in tab-group directives, valibot first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LadyBluenotes
approved these changes
Aug 17, 2026
Key every Valibot/Zod tab group as tab-group[validation-library] and teach osmium's DirectiveContainer to honor the key the way SolidBase's default theme does: a persisted signal (cookie storage, BroadcastChannel sync) drives keyed groups, so selecting a library in one group updates every group and persists across pages. Keyless groups stay uncontrolled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pairs every zod validation example in the v2 docs with a valibot version in a Valibot/Zod tab group (valibot first, matching the fullstack templates' switch in solidjs/templates#276):
UserName,CreateUserwithrespond, and the routerquery/actionintegration)renameCurrentUservalidation exampleenv.tsschema (zod'sz.preprocessmaps to av.pipewithv.transform); the prose now says the fullstack template uses Valibot, but any Standard Schema library worksenv.tsexampleSynced tab groups
All groups share a key (
::::tab-group[validation-library]), so picking a library in one group updates every group and persists across pages. SolidBase's default theme already supports keyed groups, but osmium'sDirectiveContaineroverrides it — this PR ports the same logic (persisted signal with cookie storage +BroadcastChannelsync via@solid-primitives/storage) into the osmium theme. Keyless tab groups still render uncontrolled.Verified in the dev server: all five groups render, switch together, and the selection carries across pages via the
tab-group:validation-librarycookie.🤖 Generated with Claude Code