Skip to content

fix(2.0): incomplete chunk header #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkskyum merged 2 commits into from
Aug 19, 2026
+11 −2
Merged

fix(2.0): incomplete chunk header #2299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd8856
fix: incomplete chunk header
lxsmnsyc Aug 19, 2026
4570963
Create loose-stars-greet.md
lxsmnsyc Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loose-stars-greet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

fix potentially incomplete first chunk for chunk readers
8 changes: 6 additions & 2 deletions packages/start/src/fns/serialization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,14 @@ export class SerovalChunkReader {
}

async next(): Promise<{ done: true; value: undefined } | { done: false; value: string }> {
// Check if the buffer is empty
if (this.buffer.length === 0) {
// Check if the buffer is empty or incomplete
if (this.buffer.length < 12) {
// if we are already done...
if (this.done) {
// incomplete stream
if (this.buffer.length !== 0) {
throw new Error("Malformed server function stream.");
}
return {
done: true,
value: undefined,
Expand Down
Loading