fix: respect Vite base in production asset URLs - #2305
Merged
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 42153ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
birkskyum
marked this pull request as ready for review
August 20, 2026 21:14
brenelz
approved these changes
Aug 20, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the base-path portion of #2288. Nitro's static-preset build failure was fixed separately by nitrojs/nitro#4509.
Testing
pnpm --filter @solidjs/start test:ci(102 tests)pnpm --filter @solidjs/start buildbase: "/foo/",baseURL: "/foo/", andnitro-nightly@3.0.1-20260820-204949-2b3f1011; the generated stylesheet, modulepreload, and entry-script URLs all use/foo/_build/...The Nitro reproduction included the temporary direct
destrdependency documented in unjs/unstorage#808.basefor prerendered/SSR script and asset URLs #2151