feat: custom brand theme - #10
Open
91jaeminjo wants to merge 5 commits into
Open
Conversation
Prepares custom brand theming: adds the google_fonts dependency for the display font and bundles the Inter variable font as the body font asset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds themeTemplateBrand (BrandTheme): light/dark grey-purple palettes, Inter body / Oswald display typography with per-role scale overrides, and square corners. GoogleFontResolver serves bundled families from assets and delegates the rest to google_fonts. Covered by test/theme_test.dart. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Passes themeTemplateBrand and GoogleFontResolver into standard() so the app runs with the white-label palette, Inter/Oswald fonts, and square corners. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Switches the soliplex_frontend git ref from the v0.91.0+64 tag to the feat/brand-theme-api-gaps branch, which adds the typography/font API surface (all 15 text roles, per-role family, brand font, BrandTint export) needed to fully express the brand theme. Non-breaking: analyze clean and all tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Expands BrandTypography to all 15 Material text roles with PR #75's exact metrics, routes the headline and title roles back to the body font (Inter) via per-role BrandFontRole, and adds Squada One as the brand-name family. Oswald now styles only the display roles. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
91jaeminjo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the theming outcome of soliplex/frontend#75 to this app, expressed through the current
BrandThemeAPI (PR #75's ownColorConfig/FontConfigarchitecture never merged).lib/theme.dart:themeTemplateBrand(BrandTheme) +GoogleFontResolver.main.dartpassestheme:+fontResolver:intostandard().google_fonts.What's reproduced
#6B6D7B/#B8B9C6), all rolesNot included
ThemeToggleButtonin library screens), not closable from this consumer repo.pubspec.yamltrackssoliplex_frontendat the unmerged branchfeat/brand-theme-api-gaps(commitb26556fa), which adds the typography/font API surface this theme needs (all 15 text roles, per-roleBrandFontRole, brand font,BrandTintexport). This PR should not merge before that branch lands; afterward, repin to the released tag.Testing
test/theme_test.dart— palettes lower correctly (light/dark), square shape, full type scale, per-role families, brand font, bundled-font resolver path.🤖 Generated with Claude Code