ci: migrate libyang1 deb install to libyang3#693
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sonic-buildimage no longer builds the libyang1 debs (libyang_1.0.73, libyang-cpp, python3-yang); it now builds only libyang3. Update the libyang download filter list in .azure/templates/install-dependencies.yml to use versionless libyang3 globs: drop libyang_1.0*.deb (covered by the existing libyang3_*.deb pattern) and replace libyang-*_1.0*.deb (which matched libyang-cpp and v1 libyang-dev) with libyang-dev_*.deb, dropping libyang-cpp entirely. The install step uses a generic *.deb find and needs no change. Part of sonic-net/sonic-buildimage#22385. Signed-off-by: Brad House <bhouse@nexthop.ai>
bhouse-nexthop
force-pushed
the
bhouse.libyang3-debs
branch
from
f104ab1 to
1fb82bb
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Commenter does not have sufficient privileges for PR 693 in repo sonic-net/sonic-gnmi |
rookie-who
approved these changes
Jun 3, 2026
Contributor
rookie-who
left a comment
rookie-who
left a comment
There was a problem hiding this comment.
LGTM — libyang1 download patterns removed, libyang3 equivalents in place.
vaibhavhd
approved these changes
Jun 3, 2026
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
sonic-buildimage no longer builds the libyang1 debs (
libyang_1.0.73,libyang-cpp,python3-yang); it now builds only libyang3. The sonic-gnmi CI downloads and installs libyang debs from thesonic-buildimage.common_libsbuild artifact, and the libyang1-versioned download patterns no longer match any produced artifact, which would break the dependency-install step.How I did it
Updated the libyang download filter list in
.azure/templates/install-dependencies.yml:target/debs/trixie/libyang_1.0*.deb(the v1 runtime library); the libyang3 runtime is already covered by the existingtarget/debs/trixie/libyang3_*.debpattern.target/debs/trixie/libyang-*_1.0*.deb(which matched the now-removedlibyang-cppand the v1libyang-dev) with the versionlesstarget/debs/trixie/libyang-dev_*.deb(now v3), droppinglibyang-cppentirely.All patterns are versionless globs. The install step already uses a generic
find ... -name '*.deb'invocation, so it installs whatever was downloaded and needed no change.Left unchanged:
doc/telemetry-dev-env/Dockerfilebuilds libyang 1.0.184 from CESNET source for the developer environment; it is not a sonic-buildimage build asset.Makefilecomments referencing libyang memory leaks are descriptive only and unrelated to the deb migration.How to verify it
grep -rnI 'libyang_1.0\|libyang-.*_1.0' .azure/Which release branch to backport (provide reason below if selected)
Description for the changelog
ci: migrate libyang1 deb install to libyang3 (part of sonic-net/sonic-buildimage#22385)
Link to config_db schema for YANG module changes
N/A