[Feat/#1585] SP2 솝레터 온보딩 및 이름 설정 UI#1590
Open
sonms wants to merge 3 commits into
Open
Conversation
- `SopletterOnboardingNavigation`을 추가하여 온보딩 화면으로의 경로 정의 및 이동 함수 구현 - `SopletterOnboardingScreen` 및 `SopletterOnboardingRoute` 구현 - `OnboardingInfoHolder`와 `SopletterButton`을 포함한 온보딩 UI 레이아웃 구성
- `SopletterOnboardingScreen` 및 `OnboardingInfoHolder` 컴포넌트 추가 - `SopletterNameScreen` 및 `NameInfoHolder` 닉네임 확인 UI 추가 - `SopletterNameViewModel`, `NameState`, `NameSideEffect` 등 MVI 기반 로직 구현 - `SopletterNavigation`을 통한 온보딩 네비게이션 그래프 정의
- 공통 버튼 컴포넌트 `SopletterButton` 구현 - 화면에 사용되는 이미지 리소스 추가 (`img_sopletter_mailbox`, `img_sopletter_onboarding_title`, `img_sopletter_name_letter`)
seungjunGong
approved these changes
May 25, 2026
Member
seungjunGong
left a comment
seungjunGong
left a comment
There was a problem hiding this comment.
고생하셨습니다 ~~ 탑바 공통 컴포로 분리하는거 좋습니다!
| import org.sopt.official.sopletter.name.component.NameInfoHolder | ||
|
|
||
| @Composable | ||
| fun NameRoute( |
Member
There was a problem hiding this comment.
p3: 여기에는 Sopletter prefix를 따로 붙이지 않으신 이유가 있을까요?
다른 Sopletter 관련 컴포넌트들과 네이밍을 맞추는 관점에서 prefix를 붙이는 것도 좋을 것 같아서 여쭤봅니다!
Member
Author
There was a problem hiding this comment.
엇 이름 변경하면서 Route는 깜빡한 것 같습니다! 반영하겠습니다 감사합니다 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
To Reviewers 📢
탑바 같은 경우 공통으로 구현되어야 할 수 있어서 탑바를 제외하고 구현하였습니다
나머지는 API 구현 시 붙이면서 반영하겠습니다!