chore(ci): harden CI + roadmap for fearless-utils hygiene by WRRicht3r · Pull Request #1297 · soramitsu/fearless-iOS

WRRicht3r · 2025-09-24T15:32:22Z

Notes: references:
- shared-features-spm pin 6d6cb16
- web3-swift dedupe 7.7.7
- optional Google keys injection
- FearlessKeys gated by INCLUDE_FEARLESS_KEYS

WRRicht3r · 2025-11-06T10:45:20Z

@codex critique this codebase

chatgpt-codex-connector · 2025-11-06T10:49:09Z

Summary

Added docs/CodexCritique.md documenting scene-management regressions, singleton coupling risks, and cancellation handling gaps observed in the Fearless iOS codebase. docs/CodexCritique.mdL1-L11

Testing

⚠️ Not run (docs-only change)

View task →

WRRicht3r · 2025-11-06T14:27:45Z

@codex critique this codebase

chatgpt-codex-connector · 2025-11-06T14:30:35Z

Summary

Added docs/CodexCritique.md to document scene-management gaps, singleton-heavy composition, concurrency cancellation risks, and URL handler synchronization issues in the Fearless root stack. docs/CodexCritique.mdL1-L45

Testing

⚠️ Tests not run (docs-only change)

View task →

WRRicht3r · 2025-11-06T16:47:15Z

@codex fix the codecov issues once and for all

chatgpt-codex-connector · 2025-11-06T16:52:53Z

Summary

Added a dedicated Jenkins stage that runs the simulator test matrix with coverage enabled and invokes new scripts to merge .xcresult artifacts and upload them to Codecov. JenkinsfileL45-L53 scripts/ci/export-codecov.shL1-L63 scripts/ci/upload-codecov.shL1-L70
Updated the test-matrix helper to persist result bundles for each configuration, optionally trigger coverage export, and ignored the generated coverage directory in version control. scripts/test-matrix.shL12-L154 .gitignoreL1-L4
Tuned the Codecov configuration and documented the coverage workflow so contributors can reproduce the CI behavior locally. codecov.ymlL1-L36 docs/ci/Codecov.mdL1-L29

Testing

⚠️ Not run (Xcode simulator tooling unavailable in the current container).

View task →

…les under build/coverage and ignore in git Signed-off-by: William Richter <richter@soramitsu.co.jp>

…ult Jenkins destination to generic to avoid ambiguous matches Signed-off-by: William Richter <richter@soramitsu.co.jp>

Signed-off-by: William Richter <richter@soramitsu.co.jp>

…lve ChainModel/ChainAsset/StakingType in generated mock signatures Signed-off-by: William Richter <richter@soramitsu.co.jp>

…to fearless module not SSFModels Signed-off-by: William Richter <richter@soramitsu.co.jp>

…ed mock references Signed-off-by: William Richter <richter@soramitsu.co.jp>

…ous type lookups and Cuckoo mock conformance failures\n\n- Pin app module types via typealiases (MetaAccountModel, ChainRegistryProtocol, SchedulerProtocol, etc.)\n- Pin SSF models where appropriate (RuntimeMetadataItem)\n\nThis unblocks Jenkins PR build (#1297) by removing Swift ‘ambiguous for type lookup’ errors. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…alias to to match production protocols (RuntimeProviderFactoryProtocol/Pool). Fixes mismatch errors in Jenkins PR #1297. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…riceData\n\nExpose SSFModels types to tests via central alias files to resolve 'Cannot find type … in scope' errors during Jenkins build. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…out the relationship\n\n- Check entity.propertiesByName before KVC get/set to avoid NSUnknownKeyException when older/alternate models are loaded during tests.\n- Keeps behavior unchanged when relationship exists.\n\nStabilizes unit tests on CI that load differing Core Data models (SSFAcountManagmentStorage vs local). Signed-off-by: William Richter <richter@soramitsu.co.jp>

…formables\n\n- Clean SubstrateDataModel v2–v8 and base model XML: drop customClassName on Transformable attributes (purchaseProviders, availableSources, forceSmartIds, availableAssets, assets).\n- Keeps NSSecureUnarchiveFromDataTransformer where present; no functional change.\n- Silences Core Data runtime warnings on CI. Signed-off-by: William Richter <richter@soramitsu.co.jp>

…del\n\n- AccountExportPasswordTests: stub SheetAlertPresentable.present(viewModel:from:)\n- ControllerAccountTests: stub view.didReceive(feeViewModel:)\n\nFixes intermittent Cuckoo 'No stub for method' failures on CI. Signed-off-by: William Richter <richter@soramitsu.co.jp>

- Podfile: inhibit SoraUI warnings; disable warnings-as-errors for Pods - test-matrix: allow NO_XCPRETTY=1 for raw xcodebuild output This should unblock hanging tests due to SoraUI PinView warning and provide clearer logs. Signed-off-by: William Richter <richter@soramitsu.co.jp>

Signed-off-by: William Richter <richter@soramitsu.co.jp>

…evelop - Restore fearlessTests and fearlessIntegrationTests to match origin/develop - Remove branch-only test shims and mocks This isolates recent CI failures to app code and stabilizes the test suite. Signed-off-by: William Richter <richter@soramitsu.co.jp>

@unchecked

- Add SSFModels/SSFCrypto imports to tests - Fix AccountCreationHelper to pass defaultChainId/isBackuped - Conform SubstrateStorageTestFacade to StorageFacadeProtocol - Disambiguate OperationManagerFacade type in era test - Restate @unchecked Sendable for Operation subclasses (Swift 6) Signed-off-by: William Richter <richter@soramitsu.co.jp>

- Add githubNotify-safe wrapper to set commit status context 'jenkins/ios-tests' - Wrap test stage in try/catch to mark PENDING/SUCCESS/FAILURE This ensures PRs show a Jenkins check in addition to Codecov. Signed-off-by: William Richter <richter@soramitsu.co.jp>

- Jenkinsfile: restore to pre-Codecov version - scripts/test-matrix.sh: restore pre-Codecov behavior - Remove Codecov helper scripts and doc; restore codecov.yml/.gitignore Return CI to previous process without Codecov stage. Signed-off-by: William Richter <richter@soramitsu.co.jp>

- Add ghNotifySafe helper and wrap Unit Tests with commit statuses - Run scripts/test-matrix.sh using auto-picked simulator destination This makes Jenkins appear as an independent check on PRs. Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-14T05:52:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef80742c25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-14T12:12:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8eedb65075

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-14T13:04:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 223b8c4e00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-14T17:12:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

fearless-iOS/fearless/Common/Services/ChainRegistry/ChainRegistry.swift

Lines 592 to 595 in 84d3eb2

    
           let updateClosure: ([DataProviderChange<ChainModel>]) -> Void = { changes in 
        
               runningInQueue.async { 
        
                   updateClosure(changes) 
        
               }

Call caller-provided update closure in chainsSubscribe

The local updateClosure constant shadows the function parameter, and the inner updateClosure(changes) call therefore invokes the wrapper itself rather than the caller’s callback. On any chain update this creates unbounded recursive dispatching on runningInQueue, so observers do not receive the intended update payload and the queue can be flooded. Capture the parameter under a different name and call that inside the async block.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-15T12:59:38Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c886d22be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-15T19:05:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 738c630b3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-15T22:06:24Z

@codex review

takemiyamakoto · 2026-05-16T03:42:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4c2b1482d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r · 2026-05-18T09:09:28Z

@codex review

chatgpt-codex-connector · 2026-05-18T09:16:22Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

WRRicht3r force-pushed the chore/ci-utils-roadmap-hardening branch 2 times, most recently from 9c91aeb to b7a28f0 Compare November 4, 2025 12:54

soramitsu deleted a comment from chatgpt-codex-connector Bot Nov 6, 2025

WRRicht3r added 12 commits November 6, 2025 18:09

ci: add Codecov export/upload and Jenkins stage; store .xcresult bund…

a88c2b0

…les under build/coverage and ignore in git Signed-off-by: William Richter <richter@soramitsu.co.jp>

ci(simulator): let test-matrix pick concrete simulator via UDID; defa…

59e04d5

…ult Jenkins destination to generic to avoid ambiguous matches Signed-off-by: William Richter <richter@soramitsu.co.jp>

ci: mark test-matrix.sh and coverage scripts executable for Jenkins

9fb50bd

Signed-off-by: William Richter <richter@soramitsu.co.jp>

test(mocks): add SSFModels typealiases locally in CommonMocks to reso…

6cad79d

…lve ChainModel/ChainAsset/StakingType in generated mock signatures Signed-off-by: William Richter <richter@soramitsu.co.jp>

test(mocks): correct typealiases — ChainFormat, AccountId should map …

b2fb7fc

…to fearless module not SSFModels Signed-off-by: William Richter <richter@soramitsu.co.jp>

test(mocks): add AssetModel alias to SSFModels.AssetModel for generat…

2cba6a4

…ed mock references Signed-off-by: William Richter <richter@soramitsu.co.jp>

test: align RuntimeMetadataItem alias to app type\n\nSwitch test type…

94d7804

…alias to to match production protocols (RuntimeProviderFactoryProtocol/Pool). Fixes mismatch errors in Jenkins PR #1297. Signed-off-by: William Richter <richter@soramitsu.co.jp>

test: add SSF typealiases for CryptoType, ChainNodeModel, Currency, P…

af09492

…riceData\n\nExpose SSFModels types to tests via central alias files to resolve 'Cannot find type … in scope' errors during Jenkins build. Signed-off-by: William Richter <richter@soramitsu.co.jp>

WRRicht3r force-pushed the chore/ci-utils-roadmap-hardening branch from 3e72500 to 65b012c Compare November 7, 2025 12:54

WRRicht3r force-pushed the chore/ci-utils-roadmap-hardening branch from 65b012c to 514c4e3 Compare November 7, 2025 12:58

WRRicht3r added 6 commits November 7, 2025 16:06

ci: trigger Jenkins build

064a83c

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed May 14, 2026

View reviewed changes

Comment thread fearless/Common/Services/ChainRegistry/ChainSyncService.swift

Comment thread fearless/Common/Services/ChainRegistry/ChainRegistry.swift

WRRicht3r added 2 commits May 14, 2026 10:45

fix: preserve history and ton provider selection

683e323

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix: avoid ton client factory shadowing

8eedb65

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed May 14, 2026

View reviewed changes

Comment thread fearless/ApplicationLayer/Services/WalletConnect/WalletConnectService.swift Outdated

fix: declare walletconnect storage group

223b8c4

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed May 14, 2026

View reviewed changes

Comment thread fearless/Common/Services/ChainRegistry/ChainSyncService.swift Outdated

Comment thread scripts/ci/select-simulator.sh Outdated

fix: restore history fallback and runtime ordering

84d3eb2

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed May 14, 2026

View reviewed changes

fix: call observer update closure

7c886d2

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread fearless/Modules/Send/Validators/XcmMinAmountInspectorShim.swift Outdated

WRRicht3r added 2 commits May 15, 2026 15:15

fix: restore xcm minimum amount validation

c53f783

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix: satisfy swiftformat in xcm min inspector

738c630

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread fearless/Common/Services/ChainRegistry/ConnectionPool/ConnectionFactory.swift Outdated

WRRicht3r added 2 commits May 15, 2026 21:19

fix: restore websocket node failover

c917730

Signed-off-by: William Richter <richter@soramitsu.co.jp>

fix: compile websocket failover wrapper

e4c2b14

Signed-off-by: William Richter <richter@soramitsu.co.jp>

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Comment thread Podfile

Comment thread fearless/ApplicationLayer/Services/Balance/AccountInfo/TonRemoteBalanceFetching.swift Outdated

fix: remove stale pod input and cache ton jettons

88ade7e

Signed-off-by: William Richter <richter@soramitsu.co.jp>

takemiyamakoto approved these changes May 19, 2026

View reviewed changes

takemiyamakoto merged commit 947b154 into develop May 19, 2026
1 check passed

takemiyamakoto deleted the chore/ci-utils-roadmap-hardening branch May 19, 2026 15:44

	let updateClosure: ([DataProviderChange<ChainModel>]) -> Void = { changes in
	runningInQueue.async {
	updateClosure(changes)
	}

Conversation

WRRicht3r commented Sep 24, 2025

Uh oh!

WRRicht3r commented Nov 6, 2025

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2025

Uh oh!

WRRicht3r commented Nov 6, 2025

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2025

Uh oh!

WRRicht3r commented Nov 6, 2025

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2025

Uh oh!

WRRicht3r commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

WRRicht3r commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

WRRicht3r commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

WRRicht3r commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

WRRicht3r commented May 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

WRRicht3r commented May 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

WRRicht3r commented May 15, 2026

Uh oh!

takemiyamakoto commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

WRRicht3r commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!