fix helm manifests to support 2.16 jaeger configs#841
fix helm manifests to support 2.16 jaeger configs#841
Conversation
michaellzc
left a comment
There was a problem hiding this comment.
can we update the CHANGELOG to indicate this is a breaking change?
also might want to do a changelog post in sg/sg as well
|
also CI is complaining about outdated dodcs |
@michaellzc did you mean the changelog in this repo, or the changelog product on main? The changelog in here isn't really that robust in its release tracking |
I was thinking both, but you're right. let's just do |
Chickensoupwithrice
left a comment
There was a problem hiding this comment.
other than marking as breaking change, this seems good
closes PLAT-485
Update manifests to support 2.16 jaeger configurations style
This follows changes to the sourcegraph jaeger base image https://github.com/sourcegraph/sourcegraph/pull/10912
Test plan
See testing from original PR, this version of the charts was tested via
kindTested by generating a template of the jaeger deployment and running