Skip to content

More authenticated related e2e tests#1079

Merged
jviotti merged 1 commit into
mainfrom
auth-tests-2
Jun 23, 2026
Merged

More authenticated related e2e tests#1079
jviotti merged 1 commit into
mainfrom
auth-tests-2

Conversation

@jviotti

@jviotti jviotti commented Jun 23, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@augmentcode

augmentcode Bot commented Jun 23, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Expands enterprise authentication e2e coverage to ensure protected directories cannot be enumerated without credentials.

Changes:

  • Adds a new Hurl test suite (enterprise/e2e/auth/hurl/enumeration.all.hurl) covering both the API listing endpoint (/self/v1/api/list/private) and the HTML directory surface (/private/).
  • Asserts anonymous GET/HEAD requests are consistently gated with 401 responses and RFC 9457 problem documents, including no-store caching and no ETag.
  • Validates denial and missing-resource problem bodies against the schema advertised via the Link: …; rel="describedby" header using the schema-evaluate API.
  • Verifies that once authenticated, the private listing becomes enumerable, includes expected entries/metadata, and is marked as Cache-Control: private.
  • Confirms that probing a non-existent nested path is indistinguishable pre-auth (401) but becomes a real 404 after authentication.

Technical Notes: Uses the primary-secret-key bearer token and exercises content negotiation behavior to prevent information leaks via alternate representations.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 65da4bf Previous: 0959497 Ratio
Add one schema (0 existing) 385 ms 328 ms 1.17
Add one schema (100 existing) 28 ms 22 ms 1.27
Add one schema (1000 existing) 81 ms 65 ms 1.25
Add one schema (10000 existing) 656 ms 539 ms 1.22
Update one schema (1 existing) 21 ms 16 ms 1.31
Update one schema (101 existing) 29 ms 22 ms 1.32
Update one schema (1001 existing) 84 ms 67 ms 1.25
Update one schema (10001 existing) 671 ms 549 ms 1.22
Cached rebuild (1 existing) 6 ms 4 ms 1.50
Cached rebuild (101 existing) 8 ms 5 ms 1.60
Cached rebuild (1001 existing) 29 ms 18 ms 1.61
Cached rebuild (10001 existing) 247 ms 165 ms 1.50
Index 100 schemas 659 ms 390 ms 1.69
Index 1000 schemas 1532 ms 1284 ms 1.19
Index 10000 schemas 13552 ms 10931 ms 1.24
Index 10000 schemas (custom meta-schema) 16152 ms 13523 ms 1.19
Index 10000 schemas ($ref fan-out) 16576 ms 13757 ms 1.20

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 65da4bf Previous: 0959497 Ratio
Add one schema (0 existing) 375 ms 376 ms 1.00
Add one schema (100 existing) 30 ms 32 ms 0.94
Add one schema (1000 existing) 80 ms 86 ms 0.93
Add one schema (10000 existing) 618 ms 675 ms 0.92
Update one schema (1 existing) 23 ms 24 ms 0.96
Update one schema (101 existing) 29 ms 31 ms 0.94
Update one schema (1001 existing) 79 ms 86 ms 0.92
Update one schema (10001 existing) 624 ms 686 ms 0.91
Cached rebuild (1 existing) 7 ms 8 ms 0.88
Cached rebuild (101 existing) 9 ms 10 ms 0.90
Cached rebuild (1001 existing) 29 ms 33 ms 0.88
Cached rebuild (10001 existing) 243 ms 274 ms 0.89
Index 100 schemas 637 ms 469 ms 1.36
Index 1000 schemas 1564 ms 1505 ms 1.04
Index 10000 schemas 14055 ms 13530 ms 1.04
Index 10000 schemas (custom meta-schema) 16314 ms 15954 ms 1.02
Index 10000 schemas ($ref fan-out) 16574 ms 16125 ms 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 4969c72 into main Jun 23, 2026
7 of 8 checks passed
@jviotti jviotti deleted the auth-tests-2 branch June 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant