Skip to content

Add a policies array to the directory listing results#1083

Merged
jviotti merged 4 commits into
mainfrom
policies-list
Jun 23, 2026
Merged

Add a policies array to the directory listing results#1083
jviotti merged 4 commits into
mainfrom
policies-list

Conversation

@jviotti

@jviotti jviotti commented Jun 23, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 13 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/authentication/authentication.cc
Comment thread src/self/v1/schemas/api/list/response.json
Comment thread enterprise/authentication/authentication.cc
@augmentcode

augmentcode Bot commented Jun 23, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR extends the directory listing outputs to include a new policies array, allowing clients to see which authentication policies govern a directory and each entry.

Changes:

  • Documented the new /policies and /entries/*/policies fields in the List API docs
  • Updated the List API JSON Schema (and MCP tool response example) to require policies
  • Added Authentication::governing() to expose the governing policy indices for a registry path
  • Implemented enterprise logic to derive governing policy indices from the internal policy bitmask, plus unit tests
  • Updated the explorer directory listing generator to attach policy names to the directory and each listed entry
  • Adjusted build rules so directory listings depend on authentication.bin and excluded global deps from the directory-entry limit
  • Refreshed e2e resource size assertions to match the updated schemas

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/index/explorer.h
Comment thread docs/api.md Outdated
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 6853836 Previous: 3524c2a Ratio
Add one schema (0 existing) 399 ms 387 ms 1.03
Add one schema (100 existing) 29 ms 28 ms 1.04
Add one schema (1000 existing) 84 ms 79 ms 1.06
Add one schema (10000 existing) 671 ms 620 ms 1.08
Update one schema (1 existing) 22 ms 21 ms 1.05
Update one schema (101 existing) 29 ms 27 ms 1.07
Update one schema (1001 existing) 84 ms 80 ms 1.05
Update one schema (10001 existing) 678 ms 626 ms 1.08
Cached rebuild (1 existing) 6 ms 6 ms 1
Cached rebuild (101 existing) 8 ms 8 ms 1
Cached rebuild (1001 existing) 28 ms 28 ms 1
Cached rebuild (10001 existing) 245 ms 234 ms 1.05
Index 100 schemas 503 ms 594 ms 0.85
Index 1000 schemas 1588 ms 1455 ms 1.09
Index 10000 schemas 13773 ms 13187 ms 1.04
Index 10000 schemas (custom meta-schema) 16420 ms 15675 ms 1.05
Index 10000 schemas ($ref fan-out) 16542 ms 16115 ms 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 6853836 Previous: 3524c2a Ratio
Add one schema (0 existing) 398 ms 317 ms 1.26
Add one schema (100 existing) 32 ms 25 ms 1.28
Add one schema (1000 existing) 83 ms 65 ms 1.28
Add one schema (10000 existing) 681 ms 550 ms 1.24
Update one schema (1 existing) 24 ms 18 ms 1.33
Update one schema (101 existing) 32 ms 25 ms 1.28
Update one schema (1001 existing) 86 ms 66 ms 1.30
Update one schema (10001 existing) 690 ms 541 ms 1.28
Cached rebuild (1 existing) 7 ms 5 ms 1.40
Cached rebuild (101 existing) 10 ms 7 ms 1.43
Cached rebuild (1001 existing) 30 ms 19 ms 1.58
Cached rebuild (10001 existing) 257 ms 169 ms 1.52
Index 100 schemas 683 ms 452 ms 1.51
Index 1000 schemas 1507 ms 1302 ms 1.16
Index 10000 schemas 13780 ms 11044 ms 1.25
Index 10000 schemas (custom meta-schema) 16703 ms 14111 ms 1.18
Index 10000 schemas ($ref fan-out) 16902 ms 14232 ms 1.19

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread enterprise/e2e/html/hurl/mcp-2025-11-25-resources.all.hurl
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit be4c4bc into main Jun 23, 2026
5 checks passed
@jviotti jviotti deleted the policies-list branch June 23, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant