Fix templating issues in computed values#71
Merged
Conversation
…ecognised parse.New (the raw parser) does not register Go's builtin template functions (eq, ne, and, or, not, …). When a computed value expression used one of those builtins, extractRefs silently returned nil (parse error swallowed), the topo sort saw no computed-key dependencies, and PhpDockerTag (or any such value) could be scheduled before the plain-string computed values it depends on — producing a 'map has no entry for key' error at execution time. Fix: replace parse.New(t).Parse with texttemplate.New().Delims.Funcs.Parse, the same path used by renderExpr, so both builtins and Sprout functions are available to the parser. Add a regression test that covers nested ternary with custom delimiters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Previously a parse failure in extractRefs was completely invisible — no log at any level, not even with --debug. This made the root cause of topo-sort bugs very hard to find. Now the error is emitted at slog.Debug so it shows up when --debug is passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mirrors the same improvement made to extractRefs: parse failures in analyseExpr were completely invisible at all log levels. A failing parse here causes conditional-analysis to be skipped for that expression (safe, conservative), but was impossible to diagnose. Now emits slog.Debug so --debug surfaces the issue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractRefsusingparse.New(raw parser) instead oftexttemplate.New: Go builtins likeeqwere not registered, causing silent parse failures that broke topological sort for computed values and produced misleadingmap has no entry for keyerrors at runtimeslog.DebugtoextractRefsso parse failures are visible with--debugslog.DebugtoanalyseExprfor the same reasonternarywith custom delimiters