Skip to content

Streaming modules #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gthea merged 29 commits into from
Apr 1, 2026

Fix gradle

a220fd1
Select commit
Loading
Failed to load commit list.
Merged

Streaming modules #878

Fix gradle
a220fd1
Select commit
Loading
Failed to load commit list.
SonarQube Pull Requests / SonarQube Code Analysis failed Mar 31, 2026 in 47s

Quality Gate failed

Failed conditions
11 New issues
76.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE SonarQube for IDE

Annotations

Check warning on line 109 in main/src/main/java/io/split/android/client/SplitFactoryHelper.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Split this “Monster Class” into smaller and more specialized ones to reduce its dependencies on other classes from 49 to the maximum authorized 20 or less. 

[S6539] Classes should not depend on an excessive number of classes (aka Monster Class)
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=5fb62513-814d-4fdd-a452-25dcab8191d6&open=5fb62513-814d-4fdd-a452-25dcab8191d6

Check warning on line 99 in streaming/src/main/java/io/split/android/client/service/sseclient/sseclient/EventSourceClientImpl.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Remove this useless assignment; "isErrorRetryable" already holds the assigned value along all execution paths. 

[S4165] Assignments should not be redundant
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=7d604818-4621-420b-bd36-1c4b307c6572&open=7d604818-4621-420b-bd36-1c4b307c6572

Check failure on line 62 in streaming/src/main/java/io/split/android/client/service/sseclient/sseclient/EventSourceClientImpl.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

[S3776] Cognitive Complexity of methods should not be too high
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=2913d0b6-920a-451a-a72d-5aaccb56acd1&open=2913d0b6-920a-451a-a72d-5aaccb56acd1

Check warning on line 31 in main/src/main/java/io/split/android/client/service/sseclient/sseclient/SseRefreshTokenTimer.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Make this anonymous inner class a lambda 

[S1604] Anonymous inner classes containing only one method should become lambdas
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=e6d94548-3f32-4f5d-b321-18cc1b992ca8&open=e6d94548-3f32-4f5d-b321-18cc1b992ca8

Check warning on line 96 in streaming/src/main/java/io/split/android/client/service/sseclient/sseclient/EventSourceClientImpl.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Remove this useless assignment; "isErrorRetryable" already holds the assigned value along all execution paths. 

[S4165] Assignments should not be redundant
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=3314848e-c4dd-4c15-8ff2-442bb03e1543&open=3314848e-c4dd-4c15-8ff2-442bb03e1543

Check warning on line 39 in streaming/src/main/java/io/split/android/client/service/sseclient/sseclient/EventSourceClientImpl.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use a thread-safe type; adding "volatile" is not enough to make this field thread-safe. 

[S3077] Non-primitive fields should not be "volatile"
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=a533d271-cdac-4ac6-86d3-79c47fcf8f79&open=a533d271-cdac-4ac6-86d3-79c47fcf8f79

Check warning on line 37 in streaming/src/main/java/io/split/android/client/service/sseclient/sseclient/EventSourceClientImpl.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use a thread-safe type; adding "volatile" is not enough to make this field thread-safe. 

[S3077] Non-primitive fields should not be "volatile"
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=3ef42aa3-6935-47dd-9bcc-bb585cfec94b&open=3ef42aa3-6935-47dd-9bcc-bb585cfec94b

Check warning on line 37 in main/src/main/java/io/split/android/client/service/sseclient/sseclient/SseRefreshTokenTimer.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Make this anonymous inner class a lambda 

[S1604] Anonymous inner classes containing only one method should become lambdas
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=42fc110b-f69e-4ab9-81ea-b7550efa2a5a&open=42fc110b-f69e-4ab9-81ea-b7550efa2a5a

Check warning on line 157 in main/src/main/java/io/split/android/client/service/sseclient/sseclient/PushNotificationManager.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Remove this use of "getId"; it is deprecated. 

[S1874] "@Deprecated" code should not be used
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=606d02a5-edab-41d5-bf5d-5a290b1df3c0&open=606d02a5-edab-41d5-bf5d-5a290b1df3c0

Check warning on line 28 in main/src/main/java/io/split/android/client/service/sseclient/sseclient/SseDisconnectionTimer.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Make this anonymous inner class a lambda 

[S1604] Anonymous inner classes containing only one method should become lambdas
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=cd788a64-4bea-4806-8e4b-5573518383c2&open=cd788a64-4bea-4806-8e4b-5573518383c2

Check warning on line 214 in main/src/main/java/io/split/android/client/service/sseclient/sseclient/PushNotificationManager.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Make this anonymous inner class a lambda 

[S1604] Anonymous inner classes containing only one method should become lambdas
 See more on https://sonar.harness.io/project/issues?id=splitio_android-client&pullRequest=878&issues=ff1e04ad-29ef-4230-8be3-bcef3335573d&open=ff1e04ad-29ef-4230-8be3-bcef3335573d
View more details on SonarQube Pull Requests