Skip to content

MappingsEndpoint reports the context's own ID as parentId when a parent exists#50373

Merged
philwebb merged 2 commits into
spring-projects:3.5.xfrom
dlwldnjs1009:main
May 12, 2026
Merged

MappingsEndpoint reports the context's own ID as parentId when a parent exists#50373
philwebb merged 2 commits into
spring-projects:3.5.xfrom
dlwldnjs1009:main

Conversation

@dlwldnjs1009
Copy link
Copy Markdown
Contributor

Fixes #50368. MappingsEndpoint reported the context's own id as
parentId when a parent context existed, instead of the parent context's
id.

Sibling endpoints (BeansEndpoint, ConfigurationPropertiesReportEndpoint,
ConditionsReportEndpoint) already use parent.getId().

Test plan

  • MappingsEndpointTests#mappingsParentIdMatchesParentContextId — child
    descriptor's parentId equals the parent context id; root descriptor's
    parentId is null

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 8, 2026
@philwebb philwebb changed the title Fix self-referential parentId in MappingsEndpoint MappingsEndpoint reports the context's own ID as parentId when a parent exists May 12, 2026
dlwldnjs1009 and others added 2 commits May 12, 2026 12:26
The mappings endpoint reported the context's own id as `parentId`
instead of the parent context's id, preventing clients from
reconstructing the context hierarchy from the response. Align with
sibling endpoints (`BeansEndpoint`,
`ConfigurationPropertiesReportEndpoint`, `ConditionsReportEndpoint`)
which already use `parent.getId()`.

See spring-projectsgh-50373

Signed-off-by: Lee JiWon <dlwldnjs1009@gmail.com>
@philwebb philwebb changed the base branch from main to 3.5.x May 12, 2026 19:30
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 12, 2026
@philwebb philwebb modified the milestones: 3.5.x, 3.5.15 May 12, 2026
@philwebb philwebb self-assigned this May 12, 2026
@philwebb philwebb merged commit 9b00740 into spring-projects:3.5.x May 12, 2026
1 check failed
@philwebb
Copy link
Copy Markdown
Member

Thanks @dlwldnjs1009 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MappingsEndpoint reports the context's own ID as parentId when a parent exists

3 participants