Align OTLP signal-specific properties with common fallback configuration#50461
Align OTLP signal-specific properties with common fallback configuration#50461somiljain2006 wants to merge 5 commits into
Conversation
7710e2f to
ef4c20c
Compare
b67ca48 to
9b14d8b
Compare
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
9b14d8b to
9d575d7
Compare
|
Hello, thanks for the PR. the newly created class The The
All in all, I don't think extracting all the common properties you did will work, either because not all signals support all settings or we have defaults in place, which renders the fallback obsolete. It could work for Do you want to rework the PR to just target endpoint and headers? |
|
Compression could work, too, if we drop the default values in the specific classes ( for timeouts, i don't think this works as OTel uses connect timeout and timeout, while micrometer uses connect timeout and read timeout. I guess timeout from otlp is overall timeout (including connection timeout), while Micrometer's is not including connect timeout. |
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
b5e9ffb to
eaded03
Compare
Fixes #47962
Fix OTLP common property fallback handling. Align OTLP logging and tracing fallback behavior when resolving
common and signal-specific configuration properties. This change removes strict transport assertions from connection
details implementations since the effective transport may now be determined through fallback resolution between signal-specific and common OTLP properties.
Also adds regression tests covering: